[PATCH] Forcing execution of make in C locale

[Andreas Pakulat]

On 17.01.08 15:23:27, David Nolden wrote:
> On Thursday 17 January 2008 14:51:06 Andreas Pakulat wrote:
> > On 17.01.08 14:16:05, Amilcar do Carmo Lucas wrote:
> > > On Thursday 17 January 2008 11:48:29 Andreas Pakulat wrote:
> > > > OTOH it also forces all users to always see the build output in
> > > > english, and not being able to see it in another language (i.e. their
> > > > own).
> > > >
> > > > Objections? Comments?
> > >
> > > Can it be made configurable ?
> >
> > I could, I wanted to avoid the extra coding, especially as having
> > non-english output completely kills the usefulness of the outputviews
> >
> > > Can you attach the patch ?
> >
> > Sure.
> 
> I think I fixed the regular expressions for german some time. So maybe it 
> would need to check the language, and switch to english if the language is 
> unsupported. Unsupported means: Not english, not german. :)

IMHO there shouldn't be any support for non-english in the regexes for
the following reasons:

- we have to do translation ourselves, make has gettext support, but I'm
  not sure gettext supports to find the "original" message from a
  translated one. And that still leaves out gcc-messages
- its slowing down the parsing, unless one has to specifically activate
  the regexes for his language, which introduces quite some code
- maintenance nightmare
- translations of error messages are itself often useless in public
  forums unless you happen to have somebody speaking the same language
  there

So to conclude: A simple switch to activate the "forcing to english" and
thus disabling the jump-to-source is all thats needed.

Andreas

-- 
Expect a letter from a friend who will ask a favor of you.