KDE/kdevelop/plugins/documentview

Andreas Pakulat apaku at gmx.de
Mon Dec 15 18:51:39 UTC 2008


SVN commit 897320 by apaku:

Support proper unloading, including removing the toolview.
@KDevelop Devs: If anybody plays with the plugin selector and notices a
plugin that doesn't remove its toolview when unload is called, please
fix the plugin. Its as easy as adapting the diff from this commit.
CCMAIL:kdevelop-devel at kdevelop.org

 M  +2 -4      kdevdocumentviewplugin.cpp  
 M  +1 -2      kdevdocumentviewplugin.h  


--- trunk/KDE/kdevelop/plugins/documentview/kdevdocumentviewplugin.cpp #897319:897320
@@ -97,12 +97,10 @@
 {
 }
 
-bool KDevDocumentViewPlugin::isCentralPlugin() const
+void KDevDocumentViewPlugin::unload()
 {
-    return true;
+    core()->uiController()->removeToolView( factory );
 }
 
-
-
 #include "kdevdocumentviewplugin.moc"
 
--- trunk/KDE/kdevelop/plugins/documentview/kdevdocumentviewplugin.h #897319:897320
@@ -42,9 +42,8 @@
 public:
     KDevDocumentViewPlugin( QObject *parent, const QVariantList& args );
     virtual ~KDevDocumentViewPlugin();
+    virtual void unload();
 
-    // KDevelop::Plugin methods
-    virtual bool isCentralPlugin() const;
 private:
     KDevDocumentViewPluginFactory* factory;
 };




More information about the KDevelop-devel mailing list