[patch] Appwizard VCS extract method

Manuel Breugelmans mbr.nxi at gmail.com
Fri Aug 29 13:59:44 UTC 2008


On Friday 29 August 2008 12:49:54 Andreas Pakulat wrote:
> On 29.08.08 12:23:26, Manuel Breugelmans wrote:
> >  QString AppWizardPlugin::createProject(const ApplicationInfo& info)
> >  {
> >      QFileInfo templateInfo(info.appTemplate);
> >      if (!templateInfo.exists())
> > -        return "";
> > +        return QString();
>
> This isn't really needed. QString() == "" in Qt4, unless you use
> QString::isNull() which is to be avoided by all means.
>
> > +                Q_ASSERT_X(0, "AppWizardPlugin::createProject()",
> > +                               "Err? Neither a DVCS nor CVCS plugin.");
>
> You think it might make sense to just inform the user and let him decide
> to abort project creation or create without vcs-connection in case of
> errors?
>

Sure, I'm not that bothered. Probably with a little notice that this is an  
internal malfunction and should be reported. Any special KDialog for that?


Manuel




More information about the KDevelop-devel mailing list