[patch] dialog provider for projectcontroller

Manuel Breugelmans mbr.nxi at gmail.com
Mon Aug 25 16:02:16 UTC 2008


This patch introduces an extra class, IProjectDialogProvider. 
ProjectController delegates dialog creation to this one, instead of inline'd 
KDialog:: etc calls. Also some cleanups and extensions for 
ProjectControllerTest.

The reason I think this is useful:
*/ Increases testability. You can inject a provider that returns the answer 
you want [instead of actually spawning a dialog + trying to auto click it 
away]
*/ Beautifies the code somewhat, IMO
*/ Might want to use this for the ui-less thing.

Currently it resides in shell but maybe it makes more sense to have this in 
interfaces ...

Btw, Andreas, project-reloading is broken (part of this is exposed through  
the extra test in this patch)


Manuel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: projectDialogProvider.patch
Type: text/x-patch
Size: 13587 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20080825/4dbb178f/attachment.patch>


More information about the KDevelop-devel mailing list