[patch] minor builders cleanup

[Andreas Pakulat]

On 23.08.08 13:01:05, Manuel Breugelmans wrote:
> Hi,
> 
> Attached a patch that:
> 1/ Fixes a wrong if() for the qmake, cmake and custommake managers. This would 
> result in weird crashes, m_builder being an uninitialized pointer.

That part is wrong. The plugin and interface always has to exist, else
KDevelop shouldn't load the cmake plugin in the first place. Somethings
wrong with your setup.

> 2/ Add some Q_ASSERT's before returning the builder. Is this correct? The 
> IBuildSystemManager interface dox do not specify this.

The builder method must not return non-zero. I'll clarify the api docs.
A BuildSystem without builder is just a project manager ;)

> 3/ Remove unnecessary debug area number in kDebug() for cmake

That part is good I think.

Andreas

-- 
You should go home.