UI-less kdevplatform

[Aleix]

On Wed, Aug 6, 2008 at 9:38 AM, Andreas Pakulat <apaku at gmx.de> wrote:

> On 06.08.08 04:15:19, Aleix wrote:
> > On 8/5/08, Andreas Pakulat <apaku at gmx.de> wrote:
> > > On 05.08.08 04:18:56, Aleix wrote:
> > >  > - This is not very related but needed too, a method to the
> > >  > ProjectController to add a custom project in the IDE. I used it to
> > >  > instantiate a Project with a custom projectmanager without the need
> of
> > >  > a Plugin and so (even if it is an IPlugin).
> > >
> > >
> > > I don't quite understand why this is needed. Why can't you just load
> the
> > >  project the normal way? IProject isn't really supposed to be
> subclassed
> > >  outside shell/
> > I think it is useful to be able to do it without having installed the
> > whole plugin and, anyway,
>
> Which plugin are you talking about? And I still don't understand the
> use-case, when would somebody call this function? And why can't he use
> openProject.

Well, it is a code that I can't commit until I have this changes In.


>
> > >  > Index: shell/uicontroller.h
> > >  > ===================================================================
> > >  > --- shell/uicontroller.h      (revision 842215)
> > >  > +++ shell/uicontroller.h      (working copy)
> > >  > @@ -40,7 +40,7 @@
> > >  >      Q_OBJECT
> > >  >
> > >  >  public:
> > >  > -    UiController(Core *core);
> > >  > +    UiController(Core *core, bool ui=true);
> > >  >      virtual ~UiController();
> > >
> > >  Again the flag-thing. Apart from that I don't see the need for this
> > >  actually. If you create UiLessController instead of UiController when
> > >  doing non-ui Core then there's no need that UiController works without
> > >  Ui.
> > It is used because the UiLessController inherits UiController (so that
> > it works in the Core::initialize())
>
> I understand the technical need in your patch.
>
> >  - Abstract the d-pointer. > This makes the implementation a bit ugly I
> think.
>
> No, if(d) in all of UiController methods make the implementation quite
> ugly - IMHO. A shared dpointer is quite a nice thing actually.
>
Ok, I'll try to do it later today and send another patch version

Thanks,
Aleix

>
> Andreas
>
> --
> You will meet an important person who will help you advance professionally.
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20080806/cdfbe514/attachment.html>