Changes to build with CMake 2.6

[Andreas Pakulat]

On 27.04.08 19:30:57, Alexander Neundorf wrote:
> On Sunday 27 April 2008, Andreas Pakulat wrote:
> > On 27.04.08 17:14:31, Alexander Neundorf wrote:
> > > On Sunday 27 April 2008, Frederik Schwarzer wrote:
> > > > On Sunday 27 April 2008 10:26:19 Andreas Pakulat wrote:
> > > > > This problem shows up if kdelibs is built with cmake 2.4, but other
> > > > > modules are getting built with cmake 2.6. I've posted that quite some
> > > > > time ago already on the buildsystem list and AFAIK the conclusion was
> > > > > that its not supported to do that.
> > > >
> > > > Hmm, I talked to a Debian-kde guy yesterday and he said the problem ist
> > > > that cmake did some implicit linking which many devs got used to.
> > > > However he also said that kde 4.0.68 depends on cmake 2.6, so I guess
> > > > it is built with 2.6. Here i have 2.6-patch 0 RC-8.
> > > > The concusion of the debian packagers is that they start sending
> > > > patches upstream to link to every needed library explicitly.
> > > >
> > > > My setup here is a packages-based KDE installation from the Debian
> > > > experimental archive and some apps that are compiled from source.
> > >
> > > If you have very current kdelibs from debian, this is the reason why it
> > > doesn't work (I didn't want to say that the package is currently broken).
> > > They did significant modifications to the build of kdelibs, and
> > > apparently they broke the build for you:
> > > http://bugs.kde.org/show_bug.cgi?id=160976
> > >
> > > So, build it completely from the sources and let us know if you then
> > > still have problems.
> >
> > But isn't it still correct that a given application/library/plugin
> > should list all libraries it uses symbols from. i.e. if the documentview
> > uses libktexteditor.so and libkdeui it should list both in its
> > target_link_libraries (or rather the variables for both) and not depend
> > on kte pulling in kdeui, right?
> 
> Yes, but we can't fix problems caused by modifications by somebody else. We 
> can only make sure that what we have in svn works. It is not possible to 
> check that all modules build against all existing modifications out there 
> (except maybe if there was a full-time person doing only this).

Ok, I was just confirming that I don't need to revert the last 3 commits
I did to CMakeLists.txt - adding libraries to plugins which they
explicitly used.

Andreas

-- 
There was a phone call for you.