[VCS] removing showXXX

[Matt Rogers]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

- -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

- - -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Nov 13, 2007, at 11:33 AM, Andreas Pakulat wrote:

> Hi,
>
> I was about to implement showDiff() for Subversion and already  
> found it
> cool to replace the current slot for the diff-context menu with just a
> call to showDiff. But then I found some "questions":
>
> a) how to show the widget
> b) how's the lifespan of the job and the widget object
> c) how to let the widget know about the job
>
> Especially c) leads one directly to something like:
>
> DiffWidget( VcsJob* job, QWidget* parent );
>
> And when you're there, you don't actually need showDiff anymore,  
> because
> it doesn't provide anything you can't do with the
> kdevplatform-diffwidget and the normal diff() call. (I know the
> diffwidget doesn't exist yet).
>
> Same problems arise for the other showXXX methods, namely log,  
> annotate,
> change, ls and cat. For all of those we will have a widget that can
> display the result of the according VcsJob and thus the "extra  
> work" to
> display the result instead of doing something with it is practically
> non-existent.
>
> Also it removes some confusion from the API.
>
> So are there any objections against removing the showXXX methods, do I
> overlook anything?
>
> Andreas

YAY! Thanks! No objections from me.


I rule all, which means i automatically override everybody else, so  
you should go ahead and do it. ;) (j/k)
- - - --
Matt


- - -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iD8DBQFHOjIxA6Vv5rghv0cRAsuLAJ4jP2hsiY6ucn5ctwSza+wiowHSagCgkBHx
kqXaUf6s2ruyQgPcfruTA04=
=050w
- - -----END PGP SIGNATURE-----
- -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iD8DBQFHOknUA6Vv5rghv0cRAuqCAKCkfC6JVUBuWno+wtHyXvlbqsMorQCfVjEI
YBFyLMgI/5zsiPQQjqbjnoA=
=h+/Y
- -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iD8DBQFHOkrEA6Vv5rghv0cRAn/jAJ91+B3ijS3YTix2eIqmijkxsI4HTgCdGAxS
xCaFw4l0KDB/QCJPOV7UQR0=
=jcLe
-----END PGP SIGNATURE-----