IBasicVersionControl (second try)

[Andreas Pakulat]

On 31.05.07 21:01:18, Robert Gruber wrote:
> I just update and tried to compile with the changes you made within the last 24 hours.
> 
> Again I've attached a patch with the things I had to do in order to make it compile. Please take a look at it.

I think Matthew already comitted most of this.

> Although it compiles, I'm not completely sure if it is correct. 
> Due to the last changes VcsMapping::addMapping() takes a parameter of 
> type MappingFlags while VcsMapping::mappingFlags() returns 
> just MappingFlag I wasn't sure which one is correct. So I added
> the missing Q_DECLARE_FLAGS(), OK?

Thats an oversight by me, I removed the Q_DECLARE_FLAGS because it
doesn't make sense there, see below...

> I'm not fully sure what's the deal with the QFlags class and 
> the Q_DECLARE_FLAGS() macro, but why don't we use them on all
> enums?

QFlags should only be used when the parts of the enum can be combined,
that is if you can do

enum E { Foo = 1, Bar = 2 };
fun( Foo | Bar );

If you don't need that, for example as with the MappingFlag, you don't
use QFlags.

I didn't look wether we should use QFlag for the "simple" enums, didn't
get around that yet.

Having said that, I'm going to have more or less 10 days off work (a bit
search for a permanent work) and my main items for those days are the
platform module and the VCS support.

Andreas

-- 
Generosity and perfection are your everlasting goals.