VcsJob question and suggestion

[Andreas Pakulat]

On 29.05.07 17:25:52, Matthew Woehlke wrote:
> Andreas Pakulat wrote:
> > On 29.05.07 14:46:24, Matthew Woehlke wrote:
> >> Andreas Pakulat wrote:
> >>> diff returns ???
> >>>
> >>> Seems like diff got lost along the way, basically it would be just a
> >>> small class around QPair<QString,QString> for text files.
> >> Hmm... yes, that /should/ work but we may need to differentiate between 
> >> 'the files, verbatim' and 'a copy of A plus the diff (a,b)'. It seems 
> >> like QByteArray would work for binary files although I'm not very 
> >> familiar with it.
> > 
> > Yeap, seems QByteArray is fine. So we'd have a QPair<QString,QString> or
> > QPair<QByteArray,QByteArray>. Differing between two files and 1
> > file+diff can be done using the type (it is not only usable for
> > requesting, but also for checking later on).
> 
> I am missing it, where is the plugin telling you what type it gave back?

Its not there yet, as I said somehow we forgot to add a VcsDiff class.
What I meant is that we already have an enum for vcs diff types, which
we can use here too. (of course a VcsDiff::type() would never return
DontCare)

Andreas

-- 
You will be honored for contributing your time and skill to a worthy cause.