REMINDER: Final review of VCS interfaces

[Matthew Woehlke]

Ok, one comment on annotate()... it isn't clear what type of revision is 
returned (GlobalNumber or FileNumber) or if it is possible to try to 
retrieve both. What about this simple change (below)? Note that date is 
now fetched by asking for the Date type of revision. This should also 
make things easier in the case that a VCS's annotate() only returns a 
subset of the possible information.

Also we use 'author' here and 'user' in VcsEvent. Should we be 
consistent? OTOH there is a certain amount of sense in the current use 
of the terms, so I am not strongly opinionated either way.

Index: vcshelpers.h
===================================================================
--- vcshelpers.h        (revision 669527)
+++ vcshelpers.h        (working copy)
@@ -312,17 +312,12 @@
       * @param linenum the number of the line, counting from 0
       * @return the revision of the last change on the specified line
       */
-    VcsRevision revision( int linenum );
+    VcsRevision revision( int linenum, VcsRevision::RevisionType );
      /**
       * @param linenum the number of the line, counting from 0
       * @return the author of the last change on the specified line
       */
      QString author( int linenum );
-    /**
-     * @param linenum the number of the line, counting from 0
-     * @return the date of the last change on the specified line
-     */
-    QDateTime date( int linenum );
  };

  }


-- 
Matthew
"A mouse is a device used to point at the xterm you want to type in."
   --Kim Alm, A.S.R.