REMINDER: Final review of VCS interfaces

[Robert Gruber]

Hi,

I just took a look at ibasicversioncontrol.h, and as far 
as CVS is concerned, it looks pretty good.
Everything that comes to my mind is covered by 
the interface (but annotate is missing). 

But sill some questions are left:

*) CVS offers some more options that are not common and will 
   therefore not be part of the interface (i think!?)
   E.g. when adding binary file, an additional option needs to 
   be passed to "cvs add". That's why KDev3 offers two separat 
   menu entries for adding files.
   How will such "extensions" be handled? Will CvsPlugin need to 
   implement a second interface, let's say ICvs, that provides 
   an overloaded add() method?
   "cvs add" is not the only such thing, a lot of cvs actions 
   allow additional options.

*) Why is CvsJob not derived from KJob?

*) I'm not really sure what's the difference between diff() 
   and showDiff() and the other show*() methods. 
   Will the show*() methods popup a dialog showing the diff,
   the log and so on? If so, why do they return VcsJob?

Robert

-- 
Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten 
Browser-Versionen downloaden: http://www.gmx.net/de/go/browser