[VCS] Merging IAtomic* into IBasic*

[Andreas Pakulat]

On 11.05.07 11:00:41, Matthew Woehlke wrote:
> Andreas Pakulat wrote:
> > On 11.05.07 10:02:34, Matthew Woehlke wrote:
> >> Anyway if we say 'one project, one repository', then a pointer 
> >> to the project would suffice for things that only need to know the 
> >> address of the VCS server (and e.g. user name, etc).
> > 
> > No, a KUrl that is part of a project is sufficient, because you can find
> > the project from that.
> 
> Right, I'm considering a KUrl "heavier" (I guess because it imparts more 
> detailed information than the project), but as you say, either suffices.

Huh? KUrl's are shared and transferred as references, so its not heavy.
And we need the KUrl anyway, so adding a Project* pointer is just
additional parameter for no reason.

> > So there are functions in our interfaces that don't take a repo or local
> > path.
> 
> Right now change() only takes a VcsRevision. That might be the only one, 
> I haven't done an audit yet.

Ok, yeah. I think the revision should take the repo-information
(internally like the repo path for filenumbers)

> >>>> Incidentally, what happens if the plugin needs to ask you for a 
> >>>> password? Use KWallet I guess?
> >>> See above, project config file can store this.
> >> And... maybe we can have an option to not save it on disk? ;-)
> > 
> > Thats subject to the plugin implementation, [snip]
> 
> ...but then something that is not the project config is storing the 
> password? I guess you mean that it is up to the plugin implementation if 
> it wants to use the project config or has its own method?

Right (the latter one). The plugin should decide how to store
credentials, for cvs or svn you may use ssh credentials which may be
provided by an ssh-agent and thus they don't need to store anything at
all...

> So forget what I said. :-)

Hehe :)

> But I don't see why the plugin is remembering roots, wouldn't the 
> browser front-end do that?

Well, I didn't think about that too much. I guess you're right. Just
wanted to state that plain-browsing-repo-info shouldn't be stored in a
project.

> > I'd rather not call it VcsUrl but KDevelop::RepositoryAccessor or
> > something like that. Its not really a url for things like CVS or others.
> 
> That's fine, it's just a name. :-)

Good, I recall that not everybody always has this opinion about names...

Andreas

-- 
You will be surrounded by luxury.