VCS Interfaces, round 3

[Matthew Woehlke]

Andreas Pakulat wrote:
> On 04.05.07 15:17:14, Matthew Woehlke wrote:
>> Andreas Pakulat wrote:
>>> On 04.05.07 14:56:42, Matthew Woehlke wrote:
>>>> Hmm, is VcsAction (currently just an enum) extensible that way?  Or do
>>>> we need to do something (QFlags?) to make it extensible?
>>> I think we need to use QFlags, but I have to admit that I don't know how
>>> these are extended (I didn't yet look into Qt stuff that does this, if
>>> there is any) and QFlags is used for flags that can be orable most of
>>> the time.
>> Clearly I'm not real familiar with QFlags either. :-) Actually, it makes 
>> sense to have 'edit' or'd with some other actions, e.g. 'merge' and 
>> 'copy'. Right now there are MergeWithEdit and CopyWithEdit explicitly 
>> listed.
> 
> Then flags are perfectly fine, if there are certain flags that don't
> make sense to be used together we can error out or ignore them.

Ignore. :-) AFAIK there are no interfaces that /take/ a VcsAction, only 
interfaces that /return/ a VcsAction.

>> Anyway, we /could/ also just use an int and have VcsActions only as a 
>> non-limiting list of known actions.
> 
> No, at least not unless QFlags prove to be not extendable. This is a
> last-resort solution.

Works for me.

-- 
Matthew
Current geek index: 62%