VCS Interfaces, round 3

[Matthew Woehlke]

Andreas Pakulat wrote:
> On 04.05.07 14:07:39, Matthew Woehlke wrote:
>> Andreas Pakulat wrote:
>>> On 04.05.07 10:33:08, Matthew Woehlke wrote:
>>>> Matt Rogers wrote:
>>>>> Why do we have one interface that takes local paths and one that  
>>>>> takes repo paths?
>>>> Ask Andreas. :-) Personally I'd be in favor of dropping the one in 
>>>> IBasicVC (that takes local paths), you can always still use local paths 
>>>> indirectly with repositoryLocation().
>>> Uhm, actually I think I was a bit confused. Add certainly doesn't make
>>> the slightest sense to have in the repo interface. But remove does.
>> I think this conversation just wandered off and got lost. I was asking 
>> about two instances of log() (at least, that's what I remember thinking 
>> I was doing? ;-)), although you're right, IRepoVC should have a remove().
> 
> Hmm, I can't recall any discussion about removing add() from the RepoVC.
> remove() is there already (last time I looked at least).

We're talking about 
svn.kde.org/home/kde/trunk/KDE/kdevelop/lib/plugins/vcs/interfaces/irepositoryversioncontrol.h 
right?

I just added it to my copy, did 'svn up' to make sure I'm up to date, 
and I still see this:

$ svn diff irepositoryversioncontrol.h
Index: irepositoryversioncontrol.h
===================================================================
--- irepositoryversioncontrol.h (revision 661113)
+++ irepositoryversioncontrol.h (working copy)
@@ -37,6 +37,11 @@
      virtual VcsJob move( const QString& repoSrc,
                           const QString& repoDst,
                           const VcsRevision& srcRev ) = 0;
+
+    /**
+     * removes a source location in the repository
+     */
+    virtual VcsJob remove( const QStringList& repoLocations ) = 0;
  };

  #endif
$

...which will probably be committed by the time you read this, since we 
agree it should be there. Odd.

-- 
Matthew
Current geek index: 62%