VCS Interfaces, round 3

dukju ahn dukjuahn at gmail.com
Fri May 4 17:18:20 UTC 2007


2007/5/4, Matthew Woehlke <mw_triad at users.sourceforge.net>:
> Andreas Pakulat wrote:
> > On 04.05.07 10:17:40, dukju ahn wrote:
> >> For example, subversion takes 2~3 extra flags that are very useful
> >> (such as limit the number of log,
> >
> > That will be included in the interface as its really useful.
>
> Hmm, do you really think it is necessary? Even on a huge project I don't
> think retrieval takes that long (unless you have a /really/ slow
> connection), the issue is usually displaying it. And I don't see a
> problem there, we aren't talking about a console window. :-)

That's very useful. For me, it takes more than 1 minutes to see
the _full_ logs for KDE repository even in _konsole_. I live far from
germany and internet connection is slow. And not all KDE committers
don't live in europ. My case is just a real example. KDevelop should
cope with various circumstances.

> But I guess I don't see a problem, a VCS that can't limit the result
> (um... like I don't think perforce does it, at least it doesn't seem to
> do it /correctly/ even though it claims it can) can either artificially
> strip the results or (my preference) simply ignore the limit. IOW the
> limit would be advisory.

Then how about making the argument just a recommendation?
The caller can specify limit arguement, but there is no guarantee
that actual returned result is limited to given arguement.

Anyway limiting argument example in log() was just one example to
question how each VCSs can maintain its full flexibility that is offered
by origianl VCSs. In summary, we can derive ISubversionXXX. And
showCommit() showLog() showDiff() methods can invoke its own
option dialogs. But the other methods (commit(), log(), diff() or
copy, move, revert, update) should not invoke any GUI.
Did I summarized correctly??

> I realized just now, log() should take a VcsRevision also (should it
> not?), especially if it takes a limit, that way incremental searches are
> possible. Before I change it (or, you're welcome to do it yourself of
> course), what's the word on having two versions of log()?

Yes it should take revision or revision range.




More information about the KDevelop-devel mailing list