[kdev 4] missing line?

[Jens Herden]

The code is now in KDevPlatform but the question is still valid ;-)

Jens

On Friday 20 April 2007, Jens Herden wrote:
> Hi,
>
> in iplugin.cpp I see this:
>
> KIconLoader *IPlugin::iconLoader() const
> {
>     if ( d->iconLoader == 0 ) {
>         d->iconLoader = new KIconLoader( componentData().componentName(),
> componentData().dirs() );
>         d->iconLoader->addAppDir( "kdevelop" );
>
> I think that the addAppDir() makes sure that the icons from KDevelop are
> always found, even if the app is something else, like Quanta.
>
> Later on there is:
>
> void IPlugin::newIconLoader() const
> {
>     if (d->iconLoader) {
>         d->iconLoader->reconfigure( componentData().componentName(),
> componentData().dirs() );
>     }
> }
>
> Here the iconLoader gets reconfigured but "kdevelop" is not added again.
> This smells wrong for me and I think the addAppDir() must get called here
> again, right?
>
> Jens


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20070621/52ac0ed5/attachment.sig>