IBasicVersionControl (second try)

[Robert Gruber]

On Thu, 31 May 2007 21:50:49 Andreas Pakulat wrote:

> On 31.05.07 21:01:18, Robert Gruber wrote:
> > I just update and tried to compile with the changes you made within the
> last 24 hours.
> > 
> > Again I've attached a patch with the things I had to do in order to make
> it compile. Please take a look at it.
> 
> I think Matthew already comitted most of this.
> 
> > Although it compiles, I'm not completely sure if it is correct. 
> > Due to the last changes VcsMapping::addMapping() takes a parameter of 
> > type MappingFlags while VcsMapping::mappingFlags() returns 
> > just MappingFlag I wasn't sure which one is correct. So I added
> > the missing Q_DECLARE_FLAGS(), OK?
> 
> Thats an oversight by me, I removed the Q_DECLARE_FLAGS because it
> doesn't make sense there, see below...


I've update my working copy and it compiles fine now, thanks.

I've got one more question about the interface.
Why does showCommit() take "const QString& message" as 
parameter, shouldn't it be asking for it by itself?
I think this parameter can be removed, couldn't it?


Robert





-- 
Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten 
Browser-Versionen downloaden: http://www.gmx.net/de/go/browser