kdevplatform krazy

[Andreas Pakulat]

On 17.07.07 00:56:48, Bernd Buschinski wrote:
> a patch for kdevplatform which tries to reduce the krazy issues.
> I currently have time (school is done and I have to wait until study begins)
> so I like to help, is it possible to get a svn account?

Oh, right. Instructions how to get an svn account are on
techbase.kde.org. Basically you send a mail to the sysadmins and
explain what you want to do and why you want an svn account. I think
they then contact the maintainer of the module you want to work on and
he can approve or refuse the account.

Comments inline.

> ===================================================================
> --- language/duchain/duchainbase.cpp	(revision 688601)
> +++ language/duchain/duchainbase.cpp	(working copy)
> @@ -22,16 +22,22 @@
>  namespace KDevelop
>  {
>  
> +class DUChainBasePrivate
> +{
> +public:
> +  DUChainBasePointer basePointer;
> +};
>  
>  DUChainBase::DUChainBase(KTextEditor::Range* range)
> -  : KDevelop::DocumentRangeObject(range), m_ptr( new DUChainPointerData(this) )
> +  : KDevelop::DocumentRangeObject(range), d( new DUChainBasePrivate() )
>  {
> -  m_ptr->d = this;
> +  d->basePointer = new DUChainPointerData(this);
>  }

I'll let David comment on this one, he introduced the Pointer stuff and
removed the private class. He didn't yet tell wether the private should
be added or a krazy exclude for the dpointer check...

> Index: language/duchain/parsingenvironment.h
> ===================================================================
> --- language/duchain/parsingenvironment.h	(revision 688601)
> +++ language/duchain/parsingenvironment.h	(working copy)
> @@ -26,6 +26,8 @@
>  
>  namespace KDevelop {
>  
> +class IdentifiedFilePrivate;
> +
...
> @@ -54,8 +60,7 @@
>      ///Gives a short description(url identity)
>      QString toString() const;
>    private:
> -    KUrl m_url;
> -    uint m_identity;
> +    IdentifiedFilePrivate* const d;

The class declaration and the dpointer are preferred in a single line:

class IdentifiedFilePrivate* const d;

> +++ language/duchain/duchainbase.h	(working copy)
> @@ -28,6 +28,7 @@
>  
>  class TopDUContext;
>  class DUChainBase;
> +class DUChainBasePrivate;

Same thing here.

Andreas

-- 
Domestic happiness and faithful friends.