Patch to fix 139120 in AM

[Matt Rogers]

On Sunday 14 January 2007 5:33 pm, Jens Dagerbo wrote:
> On Monday 15 January 2007 00:21, Andreas Pakulat wrote:
> > Hi,
> >
> > the attached patch fixes the crash reported in 139120. The problem seems
> > to be that there are listviewitems created upon class creation (or maybe
> > already when creating a subproject), but those are then taken out from
> > the lower listview again. Later on when changing the selection to
> > another subproject the slot iterates over all existing targets, instead
> > of only over the ones that actually are in the listview. The patch
> > changes this to only iterate over the top-level listviewitems. The same
> > method works in the QM since "ever" (it was used before I took it over),
> > so it should be safe. Nevertheless I'm posting here as it might have
> > side-effects I'm not aware of.
> >
> > As this should go in before 3.4.0, as soon as more than just me an
> > teatime agree to apply it please somebody do the commit and close the
> > bugreport along the way.
> >
> > Andreas
>
> Just to add: I tried it and it appears to work perfectly. There has been
> crashes in the AM off and on, and I wonder if the code Andreas replaces
> here isn't responsible for a large part of then. And, again, since this
> approach is used in the QM, the code isn't really new and untested.
>
> I say commit.
>
>

Yes, please commit.
-- 
Matt