[kdev 4] missing line?

[Jens Herden]

Hi,

in iplugin.cpp I see this: 

KIconLoader *IPlugin::iconLoader() const
{
    if ( d->iconLoader == 0 ) {
        d->iconLoader = new KIconLoader( componentData().componentName(), 
componentData().dirs() );
        d->iconLoader->addAppDir( "kdevelop" );

I think that the addAppDir() makes sure that the icons from KDevelop are 
always found, even if the app is something else, like Quanta.

Later on there is:

void IPlugin::newIconLoader() const
{
    if (d->iconLoader) {
        d->iconLoader->reconfigure( componentData().componentName(), 
componentData().dirs() );
    }
}

Here the iconLoader gets reconfigured but "kdevelop" is not added again. This 
smells wrong for me and I think the addAppDir() must get called here again, 
right?

Jens

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20070420/9bdf8210/attachment.sig>