uninitialized pointer in QMake::AssignmentAST

Stephan Diederich stephan.diederich at googlemail.com
Mon Oct 30 18:25:56 UTC 2006


Hi,

patch below solves (at least for me) a bug with qmake-manager.
Changing something on a qmake-project file crashed kdevelop and left
an empty .pro-file.
Initializing the QMake::AST* commentnode pointer to zero solved that.

apaku: Maybe delete it in the destructor...?

HTH,
Stephan

Index: buildtools/lib/parsers/qmake/qmakeast.h
===================================================================
--- buildtools/lib/parsers/qmake/qmakeast.h     (Revision 600437)
+++ buildtools/lib/parsers/qmake/qmakeast.h     (Arbeitskopie)
@@ -163,7 +163,7 @@
 */
 class AssignmentAST: public AST {
 public:
-    AssignmentAST(): AST(AST::AssignmentAST) {}
+    AssignmentAST(): AST(AST::AssignmentAST), commentnode(0){}

     virtual void writeBack(QString &buffer);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qmakeast.diff.bz2
Type: application/x-bzip2
Size: 286 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20061030/3f6f707f/attachment.bin>


More information about the KDevelop-devel mailing list