branches/kdevelop/3.4/languages/cpp
David Nolden
david.nolden at art-master.de
Sat May 20 10:06:51 UTC 2006
Hi, thanks for fixing :)
But there's two issues.. I would fix it myself but my girlfriend is here, so I
don't have time until sunday evening.
Am Samstag, 20. Mai 2006 10:32 schrieb Andras Mantia:
> @@ -2006,7 +2006,8 @@
> Typedef = 4,
> Template = 8,
> NestedType = 16,
> - Namespace = 32
> + Namespace = 32,
> + Invalid = 0xffffffff
Just for the understanding, this should be called "AllTypes" instead of
"Invalid", because it covers the bits of all types :) but that's not all that
important.
Much more important:
> @@ -5773,7 +5774,7 @@
>
>
> bool CppCodeCompletion::mayBeTypeTail( int line, int column, QString&
> append, bool inFunction ) { -QString tail = clearComments(
> m_activeEditor->text( line, column+1, line+10 > m_activeEditor->numLines()
> ? m_activeEditor->numLines() : line + 10, 0 ) ); +QString tail =
> clearComments( m_activeEditor->text( line, column+1, line+10 >
> (int)(m_activeEditor->numLines() ? m_activeEditor->numLines() : line + 10),
> 0 )); tail.replace("\n", " ");
This is wrong bracketing, "line+10 > (int)(m_activeEditor->numLines() ?
m_activeEditor->numLines() : line + 10)" always evaluates to 0 or 1, this
should be "line+10 > (int)m_activeEditor->numLines() ?
(int)m_activeEditor->numLines() : line + 10"
This should be changed fast since it should create problems :)
greetings, David
More information about the KDevelop-devel
mailing list