KDE/kdevelop/lib

[Matt Rogers]

On Thursday 17 August 2006 01:25, Andras Mantia wrote:
> On Thursday 17 August 2006 02:57, Matt Rogers wrote:
> > On Wednesday 16 August 2006 11:11, Andras Mantia wrote:
> > > SVN commit 573550 by amantia:
> > >
> > > Make this methods virtual, so one can override them (project is
> > > even override in kdevgenericimporter, which is certainly not good
> > > if it is not virtual).
> > >
> > > CCMAIL: kdevelop-devel at kdevelop.org
> >
> > Why do these methods need to be virtual? They shouldn't need to be,
> > but my idea of what the code should be and what it actually is at
> > this point may not match
>
> Well, when you create a filemanager implementation, you would need to
> return the top item you created in import, not? So you have to override
> "top" in your implementation.
>
> For project, I don't care about being virtual or not, but it was already
> overridden in the genericimporter, so I thought it makes sense to make
> it virtual as well (but from the code I have the feeling that the
> genericimporter method can be removed).
>
> Andras

the generic importer method should be removed, you are correct. I wonder if a 
setTop function or an m_top protected member should be used here rather than 
making top() virtual. I have no preference as to which one to use though.
--
Matt