[PATCH] KDevCustomProject::runDirectory

Vladimir Prus ghost at cs.msu.su
Mon Jul 11 15:11:07 UTC 2005


Amilcar do Carmo Lucas wrote:

> On Monday 11 July 2005 11:41, Vladimir Prus wrote:
>> Fix a bug and eliminate code duplication in KDevProject::runDirectory.
>>
>> 1. When 'mainprogram' was a simple name (e.g. 'print_pointers') and run
>>    directory radio value was "executable", the code in
>>    KDevCustomProject::runDirectory, and many other project kinds,
>>    would concatenate projectDirectory() with the name of main target.
>>    That give full paths to executable, not a directory of executable,
>>    which is needed. For example, for executable e 'foo/print_pointers' we
>>    got get '/tmp/project/foo', but for executable name
>>    'print_pointers' we got '/tmp/project/print_pointers'.
>>    The fix is trivial.
>>
>> 2. The same runDirectory logic was repeated for most project plugins.
>>    This patch introduces base KDevProject::defaultRunDirectory, which
>>    is called from derived class' runDirectory method, with specific name
>>    of plugin.
>>
>> Okay to commit?
> yes. 

Committed.

> The original code is mine and I had to duplicate it all over the 
> place
> because I was not supposed to add stuff to  KDevProject.
> 
> But now things have
> changed and we can do all kinds of stuff with KDevProject.

Can you tell why it was not possible to do anything with KDevProject
previously?

- Volodya







More information about the KDevelop-devel mailing list