fix kdevelop's kdelibs detection

Richard Lärkäng nouseforaname at home.se
Sun Nov 7 13:27:03 UTC 2004


On Sunday 07 November 2004 11.36, Richard Dale wrote:
> On Sunday 07 November 2004 05:04, Matt Rogers wrote:
> > Hi,
> >
> > The following patch fixes kdevelop's kdelibs detection. It should keep
> > kdevelop's local copy from being for those that have it.
>
> I'm not much of an autoconf expert, but doesn't the patched version test
> for an exact match or not against KDE version 3.2.90, whereas the original
> was testing for less than that version?
>
> -      #if KDE_VERSION < ((3<<16) | (2<<8) | (90))
> +      #if !KDE_IS_VERSION(3,2,90)

No, it's just that the name is rather confusing, from kdeversion.h:
#define KDE_IS_VERSION(a,b,c) ( KDE_VERSION >= KDE_MAKE_VERSION(a,b,c) )

So they're doing the same thing.

>
> -- Richard




More information about the KDevelop-devel mailing list