[PATCH] Load CvsService asynchronously
Hamish Rodda
rodda at kde.org
Mon Feb 23 06:32:12 UTC 2004
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
With my recent patches to kdevelop, cvsservice is the slowest part to load at
the moment, due to waiting on the external DCOP service to start. I have
patched it to load the service asynchronously and (hopefully) not crash when
it doesn't load (which it seemed from my reading of the code that in the
past, it would show a nice dialog then proceed to crash anyway?). This makes
cvsservice one of the fastest to load :)
I haven't tied in displaying the error message yet (see FIXME), because at the
moment I don't know of a way to tell when an error has occurred (perhaps we
could have a single shot timer with a sane delay eg. 10 - 20s that gets
cancelled on successful load). Ideally we would turn KDCOPServiceStarter
into a QObject which could handle the async loading and properly report an
error, but that would be KDE4 material...
Please review.
Cheers,
Hamish.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAOZAaH8BtnSmIlUYRAs2VAJ98aCCa4WT3/5YcG5IQFkHvESptXQCglnXi
UtbkVqEfwXfHrMQN4FpO5EE=
=XsDi
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdevelop-cvsservice-20040223.patch
Type: text/x-diff
Size: 9639 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20040223/2629000c/attachment.bin>
More information about the KDevelop-devel
mailing list