qt/kde305 patch

[Izo]

Dominik Haumann wrote:

>Hi Iztok,
>
>  
>
>>This builds kdevelop3 for kde-3.0.5 and qt-3.0.5.
>>    
>>
>thanks for the patch! but...
>I replaced
>- (*it).replace("APPNAMEUC", getProjectName().upper());
>- (*it).replace("APPNAMELC", getProjectName().lower());
>- (*it).replace("APPNAME", getProjectName());
>with
>+ (*it) = (*it).replace(QRegExp("APPNAMEUC"), getProjectName().upper());
>+ (*it) = (*it).replace(QRegExp("APPNAMELC"), getProjectName().lower());
>+ (*it) = (*it).replace(QRegExp("APPNAME"), getProjectName());
>that should work for kde >= 3.0.x and kde 3.1.x and upcoming 3.2.
>Please test, whether you can compile now on kde 3.0.x!
>I myself have >= 3.1.3 and CVS head and it works fine.
>  
>
Yes of course. But I assume that some day the qt-3.0.x will become 
obsolete and thus using QRegExp results as overhead. I assume that some 
day in the  future (e.g. in 2-3 years) somebody will roll around all 
those #ifdefs referencing qt/kde-3.0.x and purge them out of the 
codebase. Anyway, using QRegExp on the whole or only as the 
compatibility issue should be the standard set by the KDevelopers' 
"council" and I am just not in position to decide so I always use two 
branches in such occasions.

>regarding to [1]
>
>I'm not sure about that: marioS added $(LIB_KUTILS) in revision 1.36.
>So this is not (yet) commited...
>  
>
I build KDevelop regularly on following target combinations:

qt-3.0.4, kdelibs-3.0.5, gcc-2.95.3
qt-3.0.5, kdelibs-3.0.5, gcc-3.2
qt-3.2.1, kdelibs-3.1.4, gcc-3.2
qt-3.2.1, kdelibs-3.1.92, gcc-3.2

And *no* combination needs $(LIB_KUTILS) ! So I would suggest Mario to 
reconsider and explain this entry and confirm its need and how to solve 
the problem then for kdelibs<<3.1.92.

Regards, Iztok

>regards,
>Dominik
>---
>[1]
>Index: editors/qeditor/Makefile.am
>===================================================================
>RCS file: /home/kde/kdevelop/editors/qeditor/Makefile.am,v
>retrieving revision 1.38
>diff -r1.38 Makefile.am
>23c23
>< libqeditorpart_la_LIBADD = $(LIB_KPARTS) $(LIB_KFILE) $(LIB_KUTILS) 
>-lktexteditor $(top_builddir)/lib/util/libkdevutil.la $(top_builddir)/lib/
>interfaces/libkdevinterfaces.la
>---
>  
>
>>libqeditorpart_la_LIBADD = $(LIB_KPARTS) $(LIB_KFILE) -lktexteditor 
>>    
>>
>$(top_builddir)/lib/util/libkdevutil.la $(top_builddir)/lib/interfaces/
>libkdevinterfaces.la
>
>_______________________________________________
>Kdevelop-devel mailing list
>Kdevelop-devel at barney.cs.uni-potsdam.de
>http://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>
>  
>