[PATCH] Left-handed mouse problem

Ravikiran Rajagopal ravi at ee.eng.ohio-state.edu
Fri May 9 21:42:07 UTC 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,
  In HEAD, if you use left-handed mice, right-clicking on tabs produces the 
context menu, which it should not for left-handed users. The problem is that 
the code tries conversions that Qt already does. See the note next to the 
Qt::LeftButton enum here:
  http://doc.trolltech.com/3.1/qt.html#ButtonState-enum
The following patch fixes it. Can I apply it? As a left-handed user, this is 
the most annoying problem I have found with gideon.

Regards,
Ravi

Index: ktabwidget.cpp
===================================================================
RCS file: /home/kde/kdevelop/lib/widgets/ktabwidget.cpp,v
retrieving revision 1.5
diff -u -p -w -r1.5 ktabwidget.cpp
- --- ktabwidget.cpp      18 Mar 2003 18:09:54 -0000      1.5
+++ ktabwidget.cpp      9 May 2003 19:39:55 -0000
@@ -11,7 +11,6 @@

 #include <qpopupmenu.h>

- -#include <kglobalsettings.h>
 #include <kglobal.h>
 #include <klocale.h>
 #include <kicontheme.h>
@@ -51,12 +50,7 @@ void KTabBar::closeOthersSlot()

 void KTabBar::mousePressEvent(QMouseEvent *e)
 {
- -  bool rb = (e->button() == RightButton);
- -  bool lb = (e->button() == LeftButton);
- -  int handed = KGlobalSettings::mouseSettings().handed;
- -
- -  if((rb && handed == KGlobalSettings::KMouseSettings::RightHanded) ||
- -     (lb && handed == KGlobalSettings::KMouseSettings::LeftHanded)) {
+  if(e->button() == Qt::RightButton) {

     QTab *tab = selectTab(e->pos() );
     if( tab == 0L ) return;
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+vARQbI8Y8y0oVXcRAvsMAKCJGMQTpYYuM2KiifugrLFebv+PlACfbtXZ
LhFykcrc8sNtjk169bd4gqY=
=/X06
-----END PGP SIGNATURE-----




More information about the KDevelop-devel mailing list