Fwd: if();

[jbb]

Those kdevelop if's are there for a purpose but this code is very strange. The 
getInfo actually _sets_ the variable which makes for obscure code (and couple 
this with passing addresses of methods in c++, it is definately odd).

If no-one wants to do this I'll change it, however I've never run this code 
and I don't plan on testing any changes I do here. If I was the owner I'd not 
let me do this :-)

jbb

----------  Forwarded Message  ----------

Subject: if();
Date: Thu, 12 Jun 2003 05:47
From: George Staikos <staikos at kde.org>
To: kde-core-devel at kde.org

I found these in cvs so far.  They're  if() statements with empty
consequences.  I am hesitant to touch most of them because they of course
change the flow of the code.  It would be good if the authors could review
them to see what needs to be done.

./kdebase/kioslave/imap4/imapparser.cc:  if (parseOneNumber (inWords, size));
./kdebase/kioslave/imap4/imapparser.cc:  if (value);
./kdebase/ksplashml/wndmain.cpp:  if(name.isNull());
./koffice/lib/koscript/koscript_func.cc:  if ( !KSUtil::checkArgumentsCount(
context, 2, "arg", true ) );
./koffice/filters/kspread/opencalc/opencalcimport.cc:  if ( !header.isNull()
);
./koffice/filters/kspread/opencalc/opencalcimport.cc:  if ( !footer.isNull()
);
./kdepim/kmail/kmgroupware.cpp:  if (cardConv.addresseeToVCard(addressee, s,
VCardConverter::v3_0));
./kdevelop/parts/distpart/specsupport.cpp:            if
(getInfo(s,"Name:",&SpecSupport::setAppName));
./kdevelop/parts/distpart/specsupport.cpp:            else if
(getInfo(s,"Version:",&SpecSupport::setAppVersion));
./kdevelop/parts/distpart/specsupport.cpp:            else if
(getInfo(s,"Release:",&SpecSupport::setAppRevision));
./kdevelop/parts/distpart/specsupport.cpp:            else if
(getInfo(s,"Vendor:",&SpecSupport::setAppVendor));
./kdevelop/parts/distpart/specsupport.cpp:            else if
(getInfo(s,"Copyright:",&SpecSupport::setAppLicense));
./kdevelop/parts/distpart/specsupport.cpp:            else if
(getInfo(s,"Summary:",&SpecSupport::setAppSummary));
./kdevelop/parts/distpart/specsupport.cpp:            else if
(getInfo(s,"Group:",&SpecSupport::setAppGroup));
./kdevelop/parts/distpart/specsupport.cpp:            else if
(getInfo(s,"Packager:",&SpecSupport::setAppPackager));



--
George Staikos

-------------------------------------------------------