[PATCH] Partially fixing bug #52788

[Andras Mantia]

Hi,

 I've already attached the patch to the bug report, but had no comments on it. 
It fixes partially the item 5 of bug #52788. The rest of the fix should go in 
the project handling code, as the "m_part->project()->allFiles();" in line 
193 of parts/fileview/filegroupswidget.cpp does not return the files from the 
top level project directory, so the GNU files (ChangeLog, Authors, etc.) are 
not even searched. The same bug can be noticed in the "File Tree", as the top 
level project files are not displayed with bold chars.
 If there are no objections, I would like to commit this code. 

 I have another addition for for the fileview part, for File Groups tree: it 
may happen that you have more files with the same name and you would like to 
group them. In this case it is impossible to know which file do you select 
from the group. As a first step, a good addition would be the relative path 
after the filename. It can be done in the same file, by changing the 
FileGroupsFileItem::FileGroupsFileItem constructore to the below:

FileGroupsFileItem::FileGroupsFileItem(QListViewItem *parent, const QString 
&fileName)
    : QListViewItem(parent, extractName(fileName) + " ["+ fileName +"]"), 
fullname(fileName)
{
    setPixmap(0, SmallIcon("document"));
}


A more elegant solution would be to display the full or relative path in a 
tooltip, and I started the implementation, but it doesn't work correctly. :-( 
I don't have time do work on it, but I can send the patch if you wish. It's 
based on a code from the Classview part (classtreebase.cpp). Even without 
this, the first proposed version may help a lot in such cases.

Andras 
-- 
Quanta Plus developer - http://quanta.sourceforge.net
KDE Desktop Environment - http://www.kde.org


-------------- next part --------------
A non-text attachment was scrubbed...
Name: filegroupswidget.diff
Type: text/x-diff
Size: 573 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20030123/2f2eaa87/attachment.bin>