header files in noinst

[Mario Scalas]

On Wednesday 03 December 2003 00:50, Sascha Cunz wrote:
> Hi Mario,
> there seems to be a mistake in lib/interfaces/Makefile.am
> kdevversioncontrol.h includes kdevvcsfileinfoprovider.h
>
> Since kdevvcsfileinfoprovider.h is not included at all in this Makefile.am,
> it won't get installed to $KDEDIR/include/kdevelop
>
> Can i commit the attached patch (which simply adds this file)?

Yes, please :-)

> I noticed this because a user in #kdevelop tried to develop a VCS-Plugin
> outside of kdevelop source tree.
>
> Maybe this is a bug in AM - looking deeper at it, i found:
> AutoMake Manager shows the file kdevvcsfileinfoprovider.h as "header in
> noinst" - but this file was not mentioned in Makefile.am at all.
> Is this desired to be so?

Ops :-( It is a public interface so it _must be_ installed ... My fault: it 
works when developing withing the kdevelop source tree but probably not when 
developing an external vcs plugin ;-/ 
The .h shoud then be removed from no_inst target.

> Cheers Sascha

Thanks :-))
Mario

-- 
Mario Scalas <marioscalas at agilemovement.it>
KDevelop developer http://www.kdevelop.org
Member of the Italian Agile Movement
homepage: http://oss-labs.homeunix.net/~mario
GnuGPG public key on keyring servers as hkp://pgp.mit.edu or hkp://
blackhole.pca.dfn.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20031203/e111d014/attachment.sig>