[Bug 56782] CVS operations give errors
Mario Scalas
mario at gicomsrl.it
Thu Apr 3 23:31:02 UTC 2003
> ------- Additional Comments From a.lucas at tu-bs.de 2003-04-03 22:52 -------
> The combined patches from Mario and Jan, plus some changes I maid seam to
> fix this bug.
Hope so :)
Anyway playing around with the CVS part I discovered this behaviour (at least
my cvs program does so ;): when I commit without a message (leave the message
in the dialog blank), cvs comply about some option to be chosen by the user.
The cvspart ignore the question and consider commit as failed but it is not
what I expect ;)
I believe that a message should be posted anyway (as good programming
practice): we have two choices that come in mind at once (well, I could be
missing something ... ;)
(1) Modify the commit dialog to ensure that the user put some text, limiting
his/her freedom but enforcing "good manners in using the repository".
(2) Permitting to leave the message blank but making cvs to add a default
comment such as a fantastic:
...
QString message = d.logMessage();
if (!message.isEmpty())
message = " -m " + KShellProcess::quote(message);
else
message = " -m " + KShellProcess::quote("<No comment for this commit>");
...
What do you think?
Regards,
Mario.
More information about the KDevelop-devel
mailing list