Gideon crashes when opening a file in MDI mode

[David Faure]

On Wednesday 22 May 2002 19:08, John Firebaugh wrote:
> On Wednesday 22 May 2002 2:34, Bernd Gehrmann wrote:
> > Correction of the patch: The same must happen in
> > PartManager::replacePart(), otherwise Konqueror crashes with the kdFatal in
> > removePart().
> >
> > Bernd.
> 
> -    delete (QWidget *)m_widget;
> +    delete (QWidget*) m_widget;
> 
> This is a useless cast anyway, no?

m_widget is a QGuardedPtr, I think the cast is necessary.

> For clarity, shouldn't we also get rid of the PartManager connecting to 
> destroyed() altogether
Yes.

> and the comment in removePart ("Warning. The part 
> could be already deleted")?
 
Well, konqueror and koffice use part manager in unthinkable ways ;)
Hmm, quick-checked, it looks like this change will not affect them.
*crossing fingers* ;)

-- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KDE, Making The Future of Computing Available Today