[PATCH] Tabbed MDI window creation fix

F@lk Brettschneider falk.brettschneider at gmx.de
Sat Aug 31 22:36:02 UTC 2002

Hi Hamish!

Hamish Rodda wrote:

>I've been using Gideon HEAD recently, and one bug was annoying me so much that 
>I've fixed it - please see the attached patch (apply in lib/qextmdi).  The 
>bug is mentioned in the TODO file:
>* UI bugs:
>  - in Tabbed Document Interface, sometimes new views will be opened in
>    the Output ToolView!
>Not being familiar with the code, I think the fix is right but it should be 
>The problem occurred mostly after compiling a project, and clicking on an 
>error message relating to a file that is not currently open.
>The bug happens because new non-toolbar windows are opened with the "parent 
>window" (better thought of as sibling window) being the current active 
>window.  If that active window (m_pDockbaseOfTabPage) happens to be a toolbar 
>window, the request to add a new non-toolbar window becomes a toolbar window.
Hmm...well. It seems to me your patch is a little bit hackish.

My advise:
In Gideon's code, before calling QextMdiMainFrm::addWindow(), set one of 
the editor views to be the active MDI view (likely by calling 
QextMdiChildView::activate()). Then a newly added MDI view will be 
docked to the tab pages.
So probably your patch to QextMDI would be necessary.

F at lk

More information about the KDevelop-devel mailing list