kdevelop speed drop

[Roland Krause]

Falk,
it's perfectly clear to me what you are trying to accomplish. 
But I think checking for whether the file is already open should be the
way to go instead of checking whether it "has_focus". 

The problem with yesterdays fix was, that if the file "gets focus" it
then "has focus" when you enter docViewManager::slot_gotFocus(),
therefore your fix would kick in every time, even the very first time. 

So I believe there should not be a fix, instead and architectural
change. If certain things have to be set only the first time a view is
opened the so be it. The slot_gotFocus() methods seems to be the wrong
place to call them. 

Also, I still can not see what this all has to do with the menu?

Roland

--- "F at lk Brettschneider" <gigafalk at yahoo.com> wrote:
> Roland Krause wrote:
> > 
> > Falk,
> > after we talked on IRC I started real testing. There are lots of
> > problems w/this fix. Windows that get focus dont get real focus
> from
> > the program, the results is that I can only search in a view that
> > initially has focus, when I focus another view, keyboard
> accelerators
> > are not available neither are menu functions, so there is not undo
> and
> > stuff. After a while KDevelop crashes.
> Sch*iße. :-(
> 
> But it's definitely the reason for the slowdown (I think jbb just
> forgot
> to call 'make install' ;). It takes quite a long time to compute all
> the
> stuff you wrote about above, that's why the delay on a flood of focus
> changes like when wandering through the mainmenu. Fortunately, my bad
> commit was _after_ the alpha2 tag of KDE.
> I've converted it back in CVS and will try to prevent slot_gotFocus
> already in QextMDI _before_ we are pending in a focus change where an
> escape is fatal. Clear? ..anyway. ;-)
> 
> Cheers,
> F at lk
> 
> _________________________________________________________
> Do You Yahoo!?
> Get your free @yahoo.com address at http://mail.yahoo.com
> 
> 
> -
> to unsubscribe from this list send an email to
> kdevelop-request at kdevelop.org with the following body:
> unsubscribe »your-email-address«

=====
--
Roland Krause
In the garage of life there are mechanics and 
there are drivers. Mechanics wanted!

__________________________________________________
Do You Yahoo!?
Yahoo! Auctions - buy the things you want at great prices
http://auctions.yahoo.com/

-
to unsubscribe from this list send an email to kdevelop-devel-request at kdevelop.org with the following body:
unsubscribe »your-email-address«