..nother patch

John Birch jbb at kdevelop.org
Thu Mar 22 04:52:39 UTC 2001


On Thu, 22 Mar 2001 16:12, Roland Krause wrote:
> Here is another patch that finishes the clean up of the BuildMake
> stuff.
>
> It also contains some additional stuff for the ctags implementation.
>
> Not enough, the patch also reallows to call a tool (e.g. nedit or vim)
> with the file in the current view as an argument. This was disabled
> after Falks MDI stuff but now works again.
>
> Additionally there is but clean up and more debug messages for the
> print stuff. This need rework but as a first shot I will do a little
> more on it later.

Hmm,

You have this at the end of your patch. Any reason for it? 
removeNullParams() is important afaik

jbb

===================================================================
RCS file: /home/kde/kdevelop/kdevelop/print/Attic/cprintdlg.cpp,v
retrieving revision 1.9.2.1.2.7
diff -u -r1.9.2.1.2.7 cprintdlg.cpp
--- kdevelop/print/cprintdlg.cpp	2001/02/25 03:59:58	1.9.2.1.2.7
+++ kdevelop/print/cprintdlg.cpp	2001/03/22 03:42:14
@@ -1130,6 +1130,9 @@
 //}

 void CPrintDlg::slotOkClicked() {
+
+    debug ("in CPrintDlg::slotOkClicked");
+
   settings = KGlobal::config();
   settings->setGroup("PrintDialog");
   settings->writeEntry("Program",programCombBox->currentItem());
@@ -1180,9 +1183,16 @@
 	globalpara = settings->readEntry("EnscriptSettings");
 	slotCreateParameters();
 	process->clearArguments();
-	*process << removeNullParams("enscript " + string + text + " " + files);
-//	cerr << "enscript " + string + text + " " + files << endl;
-	process->start(KProcess::Block,KProcess::AllOutput);
+//	*process << removeNullParams("enscript " + string + text + " " + files);
+	*process << "enscript " ;
+	*process << string ;
+	*process << text ;
+	*process << files ;
+
+	QString dbg_string = "enscript " + string + text + files ;
+	debug(string);
+
+	bool success = process->start(KProcess::Block,KProcess::AllOutput);
       }
       else {
 	settings = KGlobal::config();

-
to unsubscribe from this list send an email to kdevelop-devel-request at kdevelop.org with the following body:
unsubscribe »your-email-address«



More information about the KDevelop-devel mailing list