KDockMainWindow should get new parents!

Simon Hausmann shaus at neuro2.med.uni-magdeburg.de
Sat Jun 17 16:10:25 UTC 2000

On Sat, 17 Jun 2000, Ralf Nolden wrote:

> Falk Brettschneider wrote:
> > 
> > Hi,
> > 
> > Ralf Nolden wrote:
> > 
> > > John Birch wrote:
> > > > PS: I tried it out - it seems to work well :-)
> > >
> > > Ok, Falk - can you sort that out with Simon and put the stuff together ?
> > 
> > Just to get sure: Do you mean?:
> John, how did you get it to work ?
> Falk, you could also ask Simon. He´ll probably know best how to find a
> suitable solution.

;-) Sandy just sent me the whole thread.

Regarding the code duplication of KParts::MainWindow::createGUI : I'm in
favour of duplicating the code ;-) (at least for now, as it is binary
compatible, in contrary to changing the inherittance of
KParts::MainWindow) . But I'm waiting for David's input on this, he's
usually the person making wiser decisions about how to avoid code
duplication :-)

Regarding the KParts::PartManager-eventfilter-on-mainwindow issue:
This might indeed be a problem for a toplevel "dock" window. However the
reason why the partmanager has to be "restricted" on a certain toplevel
widget is the koffice embedding (you can have one koffice document
embedded in two different shells -> you have to treat the activation
separately) .

Well, but I see no problem with changing the toplevel widget check in the
eventfilter to work on a list of widgets (with usually only one entry, but
in case of undocked part widgets with multiple entries) .

I'll take care of adding that. (in case you agree)


More information about the KDevelop-devel mailing list