Bug#2120: marked as done (KDevelop crashes on long comments [23:38,07.10.99])

[Stephan Kulow]

Your message dated Wed, 20 Oct 1999 01:07:55 +0200
with message-id <380CF9CB.CC1BB789 at e-technik.fh-muenchen.de>
and subject line Bug#2120: KDevelop crashes on long comments [23:38,07.10.99]
has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I'm
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Stephan Kulow
(administrator, KDE bugs database)

Received: (at submit) by bugs.kde.org; 7 Oct 1999 22:01:36 +0000
>From l.lunak at sh.cvut.cz Fri Oct  8 00:01:36 1999
Received: from klokan.sh.cvut.cz ([147.32.127.208]:45071 "EHLO
        klokan.sh.cvut.cz") by max.tat.physik.uni-tuebingen.de with ESMTP
	id <S805721AbPJGWBR>; Fri, 8 Oct 1999 00:01:17 +0200
Received: from stoupa.sh.cvut.cz (stoupa.sh.cvut.cz [147.32.127.196])
	by klokan.sh.cvut.cz (8.9.3/8.8.8/Silicon Hill/Antispam/29.3.1998) with ESMTP id AAA19620
	for <submit at bugs.kde.org>; Fri, 8 Oct 1999 00:01:11 +0200
Received: from seli.sh.cvut.cz (IDENT:seli at seli.sh.cvut.cz [147.32.122.38])
	by stoupa.sh.cvut.cz (8.9.3/8.8.8/Debian/GNU) with SMTP id AAA14896
	for <submit at bugs.kde.org>; Fri, 8 Oct 1999 00:01:10 +0200
From:   Lubos Lunak <l.lunak at sh.cvut.cz>
To:     submit at bugs.kde.org
Subject: KDevelop crashes on long comments [23:38,07.10.99]
Date:   Thu, 7 Oct 1999 23:54:37 +0200
X-Mailer: KMail [version 1.0.21]
Content-Type: text/plain
MIME-Version: 1.0
Message-Id: <99100723591500.00526 at seli.sh.cvut.cz>
Content-Transfer-Encoding: 8bit
Return-Path: <l.lunak at sh.cvut.cz>
X-Orcpt: rfc822;submit at bugs.kde.org


Package: kdevelop
Version: 1.0-19991005-A
Severity: grave

Bugreport ID : 23:38,07.10.99

Originator	: Lubos Lunak
E-Mail	: l.lunak at email.cz

Subject : KDevelop crashes on long comments

Error Class	: software bug
Error Location: class tree
Priority	: medium
Bug Description ---------------------------

KDevelop crashes on comments longer than 2kB.


How to repeat the error -------------------

Open a new .cpp file and enter :
/*
now a lot of characters, at least 3000 of them or so.
If you're lucky, you may even get a permanent busy
cursor or other nice things, much more interesting
than just a crash.
*/


Bugfix or Workaround ----------------------

Sure :)  :
I think I've located the problem in file
classparser/ClassParser.cc at the beginning
( extern char comment[ 2048 ]; )
and file classparser/tokenizer.l at the beginning
( char comment[ 2048 ]; )
The simplest fix seems to be either to use QString
or a dynamically allocated array and an overflow check
in tokenizer.l . Well, maybe the simplest would be to
change that 2048 to something larger, but if I needed
more than 8000 today, maybe someone else would need
even more tomorrow.

System Information ------------------------

KDevelop version	: 1.0-19991005-A
KDE version		: 1.1.1
QT version		: 1.44
OS/Distribution	: RedHat Linux 6.0
Compiler		: egcs-1.1.2