Bug#2118: marked as done (still problems with '++' in pathnames [21:25,07.10.99])

[Stephan Kulow]

Your message dated Tue, 19 Oct 1999 18:31:18 +0200
with message-id <99101918313702.02482 at ati14>
and subject line (no subject)
has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I'm
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Stephan Kulow
(administrator, KDE bugs database)

Received: (at submit) by bugs.kde.org; 7 Oct 1999 19:36:34 +0000
>From armin at uumail.de.uu.net Thu Oct  7 21:36:34 1999
Received: from pec-1-12.tnt1.s2.uunet.de ([149.225.1.12]:14852 "EHLO
        obiwan.mingo.de") by max.tat.physik.uni-tuebingen.de with ESMTP
	id <S805715AbPJGTgO>; Thu, 7 Oct 1999 21:36:14 +0200
Received: (from armin at localhost)
	by obiwan.mingo.de (8.9.3/8.9.3) id VAA00951
	for submit at bugs.kde.org; Thu, 7 Oct 1999 21:33:53 +0200
Date:   Thu, 7 Oct 1999 21:33:53 +0200
From:   "Armin L. Schneider" <armin at uumail.de.uu.net>
Message-Id: <199910071933.VAA00951 at obiwan.mingo.de>
To:     submit at bugs.kde.org
Subject: still problems with '++' in pathnames [21:25,07.10.99]
Return-Path: <armin at uumail.de.uu.net>
X-Orcpt: rfc822;submit at bugs.kde.org


Package: kdevelop
Version: 1.0-19991003
Severity: normal

Bugreport ID : 21:25,07.10.99

Originator	: Armin L. Schneider
E-Mail	: armin at mingotronic.de

Subject : still problems with '++' in pathnames

Error Class	: software bug
Error Location: dialog editor
Priority	: low
Bug Description ---------------------------

Create a project in a directory containing '++', e.g '/home/armin/C++/blabla'.
Then create a new dialog and try to generate the sources.
You won't get sources though...
The reason for this is a Regexp-Replacement in '....kdevelop/kdlgedit/kdlgedit.cpp':

  abs_filename.replace(QRegExp(prj->getProjectDir()),"");

Please, don't use 'QRegExp' to replace strings in pathnames!!!


How to repeat the error -------------------

See description.

Bugfix or Workaround ----------------------

Apply this little patch:

*** kdlgedit.cpp.old	Wed Oct  6 12:02:44 1999
--- kdlgedit.cpp	Wed Oct  6 12:06:38 1999
***************
*** 413,419 ****
    // normalize it a little bit
    abs_filename.replace(QRegExp("///"),"/"); // remove ///
    abs_filename.replace(QRegExp("//"),"/"); // remove //
!   abs_filename.replace(QRegExp(prj->getProjectDir()),"");
    return abs_filename;
  }
    
--- 413,421 ----
    // normalize it a little bit
    abs_filename.replace(QRegExp("///"),"/"); // remove ///
    abs_filename.replace(QRegExp("//"),"/"); // remove //
!   abs_filename.remove (0, prj->getProjectDir().length());
! //  abs_filename.replace(QRegExp(prj->getProjectDir()),"");
! 
    return abs_filename;
  }


System Information ------------------------

KDevelop version	: 1.0-19991003
KDE version		: 1.1.1
QT version		: 1.44
OS/Distribution	: SuSE Linux 6.1
Compiler		: gcc version egcs-2.91.66 19990314 (egcs-1.1.2 release)