Code review
Peter Humphrey
peter at prh.myzen.co.uk
Fri Aug 23 09:43:38 BST 2019
On Wednesday, 21 August 2019 18:06:01 BST Ingo Klöcker wrote:
> The proper place for questions concerning the development of KMail is the
> kde- pim mailing list (https://mail.kde.org/mailman/listinfo/kde-pim).
So I signed up to kde-pim, and today kmail tripped up for the first time - on
a message in that list, which I include below.
Kmail wouldn't display the message; it wouldn't mark it read when I selected
it; I had to Mark-all-messages-read to lose the Unread mark; archiving Local
Folders stopped at (presumably) this message, saying a message download had
failed.
Again, to be clear, this is the first failure of kmail since I created a new
user, populated my kmail folder structure but left it otherwise empty.
I need to clear the akonadi cache of this folder, but I wanted to get this off
first in case I lose the folder's contents; do I need to akonadictl-fdisk as
well, or instead?
=============================
Return-path: <kde-pim-bounces at kde.org>
Received: from letterbox.kde.org ([46.43.1.242])
by bastion03d.mail.zen.net.uk with esmtps
(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
(Exim 4.80)
(envelope-from <kde-pim-bounces at kde.org>)
id 1i0vj6-0008Cp-Cc
for peter at prh.myzen.co.uk; Thu, 22 Aug 2019 22:38:40 +0000
Received: from letterbox.kde.org (localhost.kde.org [127.0.0.1])
by letterbox.kde.org (Postfix) with ESMTP id EDF61281572;
Thu, 22 Aug 2019 23:38:39 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kde.org; s=lists;
t=1566513520; bh=DvVt21G2BVQjFqNLUcJroo+SyS2j82BG08D/uC0Q/KM=;
h=Date:To:From:Subject:In-Reply-To:References:List-Id:
List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
From;
b=Bk9q+nJDMXjZPQvPytF/FA/
6cBkh+0EgLpI0kIbfwlaaWWfObdwsWASGSXkWdydX/
yNRFaHoKGQrYxoJ3/
mLGixAtdgJyvPLX216Fq5e5IWSAZ7k62hyVpHsPxhDP6USuK0
kEbrUEM+8nM5Op+LZYLTzNOHAVfFZ5UXuOLTnJoYQl/
paMZIOA2tBnlSit0TEQGSQs
YJ5d+VBx961qR8FCM6MWDyPwEe6LX+7Y2t9orlED3Oe+cslozs2cTS4SPdMNmwpQ43
iOm1EqggepjgmrTc/BPrM3CveSvjZX/eD5qO37q5JuHNfiYZvgPMV/AdRJuvu47yLv
E7mwMpSyniaOw==
X-Original-To: kde-pim at kde.org
Delivered-To: kde-pim at localhost
Received: from bluemchen.kde.org (bluemchen.kde.org [209.51.188.41])
by letterbox.kde.org (Postfix) with ESMTPS id 3514A281509;
Thu, 22 Aug 2019 23:38:12 +0100 (BST)
Authentication-Results: letterbox.kde.org; dmarc=none (p=none dis=none)
header.from=phabricator.kde.org
Authentication-Results: letterbox.kde.org;
spf=none smtp.mailfrom=noreply at phabricator.kde.org
Authentication-Results: letterbox.kde.org; dkim=pass (1024-bit key;
unprotected) header.d=kde.org header.i=@kde.org header.b="Hk0jX8Jg";
dkim-atps=neutral
Received: from code.kde.org (code.kde.org [IPv6:2a01:4f8:171:2687::4])
by bluemchen.kde.org (Postfix) with ESMTPS id BEFA920604;
Thu, 22 Aug 2019 18:37:52 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kde.org; s=transact;
t=1566513472; i=@kde.org;
bh=DvVt21G2BVQjFqNLUcJroo+SyS2j82BG08D/uC0Q/KM=;
h=Date:To:From:Subject:In-Reply-To:References:From;
b=Hk0jX8JgyKDOzx6j60M4Xn/FCwpji65mAGIUvcAHl2uxuvoYVdLvEfpMrsRu3gXGr
BqIncwIfsUPyC4Va1Tjz0nVWzCsKRVI/v1Fc8OcypTsqggxXBPsJxXC8xNuOYUr+wk
OYljepE8a8kIJeIZpbQ5znffmlkJ+Q3zxy0sOU8g=
Received: from [127.0.0.1] (helo=localhost.localdomain)
by code.kde.org with esmtp (Exim 4.86_2)
(envelope-from <noreply at phabricator.kde.org>)
id 1i0viJ-00056I-MJ; Thu, 22 Aug 2019 22:37:51 +0000
Date: Thu, 22 Aug 2019 22:37:51 +0000
To: sgclarkkde at gmail.com, msavoritias at tuta.io, kde at outrightsolutions.nl,
schwancarl at protonmail.com, krissn at op.pl, kde-pim at kde.org, winter at kde.org,
aheinecke at gnupg.org, chrigi_1 at fastmail.fm, montel at kde.org, vkrause at kde.org,
neton_12 at hotmail.com
From: =?utf-8?Q?Sandro_Knau=C3=9F?= <noreply at phabricator.kde.org>
Subject: D21450: WIP: Use a HeaderFormatter to seperate process/view.
Message-ID: <3b2ca2c1f7cb5849827843b839482a66 at localhost.localdomain>
X-Priority: 3
X-Mailer: PHPMailer 5.1 (phpmailer.sourceforge.net)
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-other>, <differential-updated>,
<differential-committed>
X-Herald-Rules: <9>, none
X-Phabricator-Projects: <#kde_pim>
X-Phabricator-To: <PHID-USER-lgsnpiumzmwdqktpnfkb>
X-Phabricator-To: <PHID-PROJ-3uta3oatixfsxeiahufa>
X-Phabricator-To: <PHID-USER-tqaxovv5vynvezdt33jt>
X-Phabricator-Cc: <PHID-USER-lctoofdpim63djs2wf5g>
X-Phabricator-Cc: <PHID-USER-yz5gnkcufd6dpexlebmq>
X-Phabricator-Cc: <PHID-USER-yona2ygwdwrs3gulpnjg>
X-Phabricator-Cc: <PHID-USER-v2dwmeeizfgkxh43wzby>
X-Phabricator-Cc: <PHID-USER-sdcbptm6rmge5kod7qov>
X-Phabricator-Cc: <PHID-USER-tqaxovv5vynvezdt33jt>
X-Phabricator-Cc: <PHID-USER-3o5m4hlr5zhnshtzmnzz>
X-Phabricator-Cc: <PHID-USER-lgsnpiumzmwdqktpnfkb>
X-Phabricator-Cc: <PHID-USER-vpciqiuq6sl7jcokkhsg>
Precedence: bulk
Thread-Topic: PHID-DREV-hjqvnwnnnn7ifqk7ar4r
X-Phabricator-Mail-ID: 2182603
X-Phabricator-Send-Attempt: z2ufrlnu66zvr7wx
In-Reply-To: <differential-rev-PHID-DREV-hjqvnwnnnn7ifqk7ar4r-
req at phabricator.kde.org>
References: <differential-rev-PHID-DREV-hjqvnwnnnn7ifqk7ar4r-
req at phabricator.kde.org>
Thread-Index: YzE0MDY2ZmExNDJiY2ExNjI5NmViOGIyYjI5IF1fGT8=
X-Phabricator-Stamps: actor(@knauss) application(Differential) author(@knauss)
herald(H9) monogram(D21450) object-type(DREV)
phid(PHID-DREV-hjqvnwnnnn7ifqk7ar4r) reviewer(#kde_pim) reviewer(@vkrause)
revision-repository(R94) revision-status(published) subscriber(@kde-pim)
tag(#kde_pim) via(daemon)
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="b1_3b2ca2c1f7cb5849827843b839482a66"
X-Scanned-By: MIMEDefang 2.83 on 46.43.1.242
X-BeenThere: kde-pim at kde.org
X-Mailman-Version: 2.1.26
List-Id: KDE PIM <kde-pim.kde.org>
List-Unsubscribe: <https://mail.kde.org/mailman/options/kde-pim>,
<mailto:kde-pim-request at kde.org?subject=unsubscribe>
List-Archive: <http://mail.kde.org/pipermail/kde-pim/>
List-Post: <mailto:kde-pim at kde.org>
List-Help: <mailto:kde-pim-request at kde.org?subject=help>
List-Subscribe: <https://mail.kde.org/mailman/listinfo/kde-pim>,
<mailto:kde-pim-request at kde.org?subject=subscribe>
Reply-To: D21450+public+30ae820ec689c942 at phabricator.kde.org,
KDE PIM <kde-pim at kde.org>
Errors-To: kde-pim-bounces at kde.org
Sender: "kde-pim" <kde-pim-bounces at kde.org>
X-Originating-IP: 46.43.1.242
X-Envelope-From: kde-pim-bounces at kde.org
X-Zen-PTR: Passed hostname OK
X-Zen-HELO: Passed helo OK
X-ZenAWL-Match: false
X-Zen-Test-Spam-Score: -1066
X-Zen-Test-Spam-Bar: (---------------------------------------------------)
X-Zen-Spam-Report:
DKIMWL_WHITELIST=-7.5,FIRST_RELAY_GB=-0.5,FROM_SOA_2WEEKS=0.1,MXPF_PASS=0.2,RCVD_IN_SENDERSCORE_96_100=-1,SHORTCIRCUIT=-100,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,URIBL_BARRACUDA_A=2,ZEN_HELO_PASS=-0.01,ZEN_PTR_PASS=-0.01
Received-SPF: pass (kde.org: 46.43.1.242 is authorized to use 'kde-pim-
bounces at kde.org' in 'mfrom' identity (mechanism 'mx' matched))
X-Originating-bastion03d-IP: [46.43.1.242]
X-Envelope-From: kde-pim-bounces at kde.org
X-Envelope-To: peter at prh.myzen.co.uk
X-Apparently-To: peter at prh.myzen.co.uk
X-Zen-Loop2: eec7c967b3969d37dce8abdecaa6be8b
X-Zen-Loop: 942401443a689c933b94ffed919d67f0
X-Zen-Stored: store01b.mail.zen.net.uk/1i0vj6-0007NC-Jz/2019-08-22 22:38:40
--b1_3b2ca2c1f7cb5849827843b839482a66
Content-Type: text/plain; charset = "utf-8"
Content-Transfer-Encoding: base64
VGhpcyByZXZpc2lvbiB3YXMgbm90IGFjY2VwdGVkIHdoZW4gaXQgbGFuZGVkOyBpdCBsYW5kZWQg
aW4gc3RhdGUgIk5lZWRzIFJldmlldyIuClRoaXMgcmV2aXNpb24gd2FzIGF1dG9tYXRpY2FsbHkg
dXBkYXRlZCB0byByZWZsZWN0IHRoZSBjb21taXR0ZWQgY2hhbmdlcy4KQ2xvc2VkIGJ5IGNvbW1p
dCBSOTQ6N2Q0MWU1NDUyYTMxOiBXSVA6IFVzZSBhIEhlYWRlckZvcm1hdHRlciB0byBzZXBlcmF0
ZSBwcm9jZXNzL3ZpZXcuIChhdXRob3JlZCBieSBrbmF1c3MpLgoKUkVQT1NJVE9SWQogIFI5NCBQ
SU06IE1lc3NhZ2UgTGlicmFyeQoKQ0hBTkdFUyBTSU5DRSBMQVNUIFVQREFURQogIGh0dHBzOi8v
cGhhYnJpY2F0b3Iua2RlLm9yZy9EMjE0NTA/
dnM9NTg3NjUmaWQ9NjQzNzgKClJFVklTSU9OIERF
VEFJTAogIGh0dHBzOi8vcGhhYnJpY2F0b3Iua2RlLm9yZy9EMjE0NTAKCkFGRkVDVEVEIEZJTEVT
CiAgbWVzc2FnZXZpZXdlci9zcmMvaGVhZGVyL2F1dG90ZXN0cy9kYXRhL2FsbGhlYWRlcnMubWJv
eC5odG1sCiAgbWVzc2FnZXZpZXdlci9zcmMvaGVhZGVyL2F1dG90ZXN0cy9kYXRhL2VtcHR5Lmh0
bWwKICBtZXNzYWdldmlld2VyL3NyYy9oZWFkZXIvYXV0b3Rlc3RzL2RhdGEvcmVzZW50RnJvbXRl
c3QudG1wbAogIG1lc3NhZ2V2aWV3ZXIvc3JjL2hlYWRlci9hdXRvdGVzdHMvZGF0YS9yZXNlbnRG
cm9tdGVzdC50bXBsLmh0bWwKICBtZXNzYWdldmlld2VyL3NyYy9oZWFkZXIvYXV0b3Rlc3RzL2Rh
dGEvcmVzZW50VG90ZXN0LnRtcGwKICBtZXNzYWdldmlld2VyL3NyYy9oZWFkZXIvYXV0b3Rlc3Rz
L2RhdGEvcmVzZW50VG90ZXN0LnRtcGwuaHRtbAogIG1lc3NhZ2V2aWV3ZXIvc3JjL2hlYWRlci9h
dXRvdGVzdHMvZGF0YS9yZXNlbnRmcm9tdGVzdC50bXBsCiAgbWVzc2FnZXZpZXdlci9zcmMvaGVh
ZGVyL2F1dG90ZXN0cy9kYXRhL3Jlc2VudGZyb210ZXN0LnRtcGwuaHRtbAogIG1lc3NhZ2V2aWV3
ZXIvc3JjL2hlYWRlci9hdXRvdGVzdHMvZGF0YS9yZXNlbnR0b3Rlc3QudG1wbAogIG1lc3NhZ2V2
aWV3ZXIvc3JjL2hlYWRlci9hdXRvdGVzdHMvZGF0YS9yZXNlbnR0b3Rlc3QudG1wbC5odG1sCiAg
bWVzc2FnZXZpZXdlci9zcmMvaGVhZGVyL2F1dG90ZXN0cy9kYXRhL3ZjYXJkLmh0bWwKICBtZXNz
YWdldmlld2VyL3NyYy9oZWFkZXIvZ3JhbnRsZWVoZWFkZXJmb3JtYXR0ZXIuY3BwCiAgbWVzc2Fn
ZXZpZXdlci9zcmMvbWVzc2FnZXZpZXdlcmhlYWRlcnBsdWdpbnMvZGVmYXVsdGdyYW50bGVlaGVh
ZGVyc3R5bGVwbHVnaW4vdGhlbWUvNS4yL2hlYWRlci5odG1sCgpUbzoga25hdXNzLCAja2RlX3Bp
bSwgdmtyYXVzZQpDYzoga2RlLXBpbSwgZmJhbXBhbG91a2FzLCBkdmFzaW4sIHJvZHNldmljaCwg
d2ludGVyeiwgdmtyYXVzZSwgbWxhdXJlbnQsIGtuYXVzcywgZHZyYXRpbAo=
--b1_3b2ca2c1f7cb5849827843b839482a66
Content-Type: text/html; charset = "utf-8"
Content-Transfer-Encoding: base64
PHRhYmxlPjx0cj48dGQgc3R5bGU9IiI+VGhpcyByZXZpc2lvbiB3YXMgbm90IGFjY2VwdGVkIHdo
ZW4gaXQgbGFuZGVkOyBpdCBsYW5kZWQgaW4gc3RhdGUgJnF1b3Q7TmVlZHMgUmV2aWV3JnF1b3Q7
LjxiciAvPlRoaXMgcmV2aXNpb24gd2FzIGF1dG9tYXRpY2FsbHkgdXBkYXRlZCB0byByZWZsZWN0
IHRoZSBjb21taXR0ZWQgY2hhbmdlcy48YnIgLz5DbG9zZWQgYnkgY29tbWl0IFI5NDo3ZDQxZTU0
NTJhMzE6IFdJUDogVXNlIGEgSGVhZGVyRm9ybWF0dGVyIHRvIHNlcGVyYXRlIHByb2Nlc3Mvdmll
dy4gKGF1dGhvcmVkIGJ5IGtuYXVzcykuCjwvdGQ+PGEgc3R5bGU9InRleHQtZGVjb3JhdGlvbjog
bm9uZTsgcGFkZGluZzogNHB4IDhweDsgbWFyZ2luOiAwIDhweCA4cHg7IGZsb2F0OiByaWdodDsg
Y29sb3I6ICM0NjRDNUM7IGZvbnQtd2VpZ2h0OiBib2xkOyBib3JkZXItcmFkaXVzOiAzcHg7IGJh
Y2tncm91bmQtY29sb3I6ICNGN0Y3Rjk7IGJhY2tncm91bmQtaW1hZ2U6IGxpbmVhci1ncmFkaWVu
dCh0byBib3R0b20sI2ZmZiwjZjFmMGYxKTsgZGlzcGxheTogaW5saW5lLWJsb2NrOyBib3JkZXI6
IDFweCBzb2xpZCByZ2JhKDcxLDg3LDEyMCwuMik7IiBocmVmPSJodHRwczovL3BoYWJyaWNhdG9y
LmtkZS5vcmcvRDIxNDUwIj5WaWV3IFJldmlzaW9uPC9hPjwvdHI+PC90YWJsZT48YnIgLz48ZGl2
PjxzdHJvbmc+UkVQT1NJVE9SWTwvc3Ryb25nPjxkaXY+PGRpdj5SOTQgUElNOiBNZXNzYWdlIExp
YnJhcnk8L2Rpdj48L2Rpdj48L2Rpdj48YnIgLz48ZGl2PjxzdHJvbmc+Q0hBTkdFUyBTSU5DRSBM
QVNUIFVQREFURTwvc3Ryb25nPjxkaXY+PGEgaHJlZj0iaHR0cHM6Ly9waGFicmljYXRvci5rZGUu
b3JnL0QyMTQ1MD92cz01ODc2NSZhbXA7aWQ9NjQzNzgiPmh0dHBzOi8vcGhhYnJpY2F0b3Iua2Rl
Lm9yZy9EMjE0NTA/
dnM9NTg3NjUmYW1wO2lkPTY0Mzc4PC9hPjwvZGl2PjwvZGl2PjxiciAvPjxk
aXY+PHN0cm9uZz5SRVZJU0lPTiBERVRBSUw8L3N0cm9uZz48ZGl2PjxhIGhyZWY9Imh0dHBzOi8v
cGhhYnJpY2F0b3Iua2RlLm9yZy9EMjE0NTAiPmh0dHBzOi8vcGhhYnJpY2F0b3Iua2RlLm9yZy9E
MjE0NTA8L2E+PC9kaXY+PC9kaXY+PGJyIC8+PGRpdj48c3Ryb25nPkFGRkVDVEVEIEZJTEVTPC9z
dHJvbmc+PGRpdj48ZGl2Pm1lc3NhZ2V2aWV3ZXIvc3JjL2hlYWRlci9hdXRvdGVzdHMvZGF0YS9h
bGxoZWFkZXJzLm1ib3guaHRtbDxiciAvPgptZXNzYWdldmlld2VyL3NyYy9oZWFkZXIvYXV0b3Rl
c3RzL2RhdGEvZW1wdHkuaHRtbDxiciAvPgptZXNzYWdldmlld2VyL3NyYy9oZWFkZXIvYXV0b3Rl
c3RzL2RhdGEvcmVzZW50RnJvbXRlc3QudG1wbDxiciAvPgptZXNzYWdldmlld2VyL3NyYy9oZWFk
ZXIvYXV0b3Rlc3RzL2RhdGEvcmVzZW50RnJvbXRlc3QudG1wbC5odG1sPGJyIC8+Cm1lc3NhZ2V2
aWV3ZXIvc3JjL2hlYWRlci9hdXRvdGVzdHMvZGF0YS9yZXNlbnRUb3Rlc3QudG1wbDxiciAvPgpt
ZXNzYWdldmlld2VyL3NyYy9oZWFkZXIvYXV0b3Rlc3RzL2RhdGEvcmVzZW50VG90ZXN0LnRtcGwu
aHRtbDxiciAvPgptZXNzYWdldmlld2VyL3NyYy9oZWFkZXIvYXV0b3Rlc3RzL2RhdGEvcmVzZW50
ZnJvbXRlc3QudG1wbDxiciAvPgptZXNzYWdldmlld2VyL3NyYy9oZWFkZXIvYXV0b3Rlc3RzL2Rh
dGEvcmVzZW50ZnJvbXRlc3QudG1wbC5odG1sPGJyIC8+Cm1lc3NhZ2V2aWV3ZXIvc3JjL2hlYWRl
ci9hdXRvdGVzdHMvZGF0YS9yZXNlbnR0b3Rlc3QudG1wbDxiciAvPgptZXNzYWdldmlld2VyL3Ny
Yy9oZWFkZXIvYXV0b3Rlc3RzL2RhdGEvcmVzZW50dG90ZXN0LnRtcGwuaHRtbDxiciAvPgptZXNz
YWdldmlld2VyL3NyYy9oZWFkZXIvYXV0b3Rlc3RzL2RhdGEvdmNhcmQuaHRtbDxiciAvPgptZXNz
YWdldmlld2VyL3NyYy9oZWFkZXIvZ3JhbnRsZWVoZWFkZXJmb3JtYXR0ZXIuY3BwPGJyIC8+Cm1l
c3NhZ2V2aWV3ZXIvc3JjL21lc3NhZ2V2aWV3ZXJoZWFkZXJwbHVnaW5zL2RlZmF1bHRncmFudGxl
ZWhlYWRlcnN0eWxlcGx1Z2luL3RoZW1lLzUuMi9oZWFkZXIuaHRtbDwvZGl2PjwvZGl2PjwvZGl2
PjxiciAvPjxkaXY+PHN0cm9uZz5UbzogPC9zdHJvbmc+a25hdXNzLCBLREUgUElNLCB2a3JhdXNl
PGJyIC8+PHN0cm9uZz5DYzogPC9zdHJvbmc+a2RlLXBpbSwgZmJhbXBhbG91a2FzLCBkdmFzaW4s
IHJvZHNldmljaCwgd2ludGVyeiwgdmtyYXVzZSwgbWxhdXJlbnQsIGtuYXVzcywgZHZyYXRpbDxi
ciAvPjwvZGl2Pg==
--b1_3b2ca2c1f7cb5849827843b839482a66--
=============================
--
Regards,
Peter.
Gentoo stable system, openrc-0.41.2
gcc 8.3.0, sys-kernel/gentoo-sources 4.19.66
QT 5.12.3, KDE frameworks 5.60.0, KDE plasma 5.15.5
KDE apps 19.04.3 incl KMail 19.04.3 (5.11.3), akonadi 19.04.3
dev-db/mariadb-10.2.22-r1, net-libs/webkit-gtk-2.24.2
x11-drivers/xf86-video-amdgpu 19.0.1
dev-libs/amdgpu-pro-opencl 19.10.785425-r1
More information about the kdepim-users
mailing list