[kaddressbook] [Bug 494242] Crash when trying to edit a contact

[Jonathan Marten]

https://bugs.kde.org/show_bug.cgi?id=494242

Jonathan Marten <jjm at keelhaul.me.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/pim/
                   |                            |akonadi-contacts/-/commit/f
                   |                            |11e81cebba7956f0b0aca27420a
                   |                            |b66d7da2b602
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Jonathan Marten <jjm at keelhaul.me.uk> ---
Git commit f11e81cebba7956f0b0aca27420ab66d7da2b602 by Jonathan Marten.
Committed on 10/10/2024 at 08:29.
Pushed by marten into branch 'master'.

Fix KAddressBook crash when editing a contact with nonstandard phone type

In this case PhoneComboBoxType::setType() attempts to insert the new
type as the penultimate item in the mTypeList.  However, using an
iterator for insertion appears to cause an assertion within QList.
There is no need to obtain an interator to do the insertion, the index
can be used directly.

Test case: Importing this contact into KAddressBook and attempting to
edit it will trigger the crash.

VERSION:3.0
EMAIL;TYPE=PREF,WORK:foo at bar.com
EMAIL;TYPE=WORK:info at bar.com
FN:Foo Bar
N:Bar;Foo;;Mx.;
TEL;TYPE=CELL,WORK:0000 000 0000
TEL;TYPE=HOME:01000 000000
END:VCARD

M  +1    -1   
src/akonadi-contacts-widgets/editor/generalinfoeditor/phone/phonecomboboxtype.cpp

https://invent.kde.org/pim/akonadi-contacts/-/commit/f11e81cebba7956f0b0aca27420ab66d7da2b602

-- 
You are receiving this mail because:
You are the assignee for the bug.