[kaddressbook] [Bug 494242] Crash when trying to edit a contact

[Jonathan Marten]

https://bugs.kde.org/show_bug.cgi?id=494242

Jonathan Marten <jjm at keelhaul.me.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jjm at keelhaul.me.uk

--- Comment #2 from Jonathan Marten <jjm at keelhaul.me.uk> ---
Created attachment 174589
  --> https://bugs.kde.org/attachment.cgi?id=174589&action=edit
Patch to fix the crash

Can confirm this happening.  It seems to be when the contact entry being edited
has a phone number type which is not one of the standard ones ("Home", "Work"
etc).  In this case Akonadi::PhoneComboBoxType::setType() in
src/akonadi-contacts-widgets/editor/generalinfoeditor/phone/phonecomboboxtype.cpp
tries to insert the previously unknown type into mTypeList as the penultimate
entry.  The code looks correct to me (although it's a bit clumsy), but it
crashes with the assert as per the backtrace.

The attached patch appears to fix the problem, although there may be a better
way.

-- 
You are receiving this mail because:
You are the assignee for the bug.