[akregator] [Bug 412215] zombie feed link

Carl Schwan bugzilla_noreply at kde.org
Mon Dec 23 08:59:11 GMT 2024


https://bugs.kde.org/show_bug.cgi?id=412215

Carl Schwan <carl at carlschwan.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/pim/
                   |                            |akregator/-/commit/0c869e02
                   |                            |caea41421d6a54feb2b03e3ec3a
                   |                            |a9030

--- Comment #11 from Carl Schwan <carl at carlschwan.eu> ---
Git commit 0c869e02caea41421d6a54feb2b03e3ec3aa9030 by Carl Schwan, on behalf
of Wendi Gan.
Committed on 23/12/2024 at 08:54.
Pushed by carlschwan into branch 'master'.

Fix extra empty line when adding a new feed

When a new folder is created and a feed or folder is inserted into it, an extra
empty line appears.
This happens because, in Folder::insertChild and Folder::prependChild, the node
is added to m_children first. If the folder is newly created, during
SubscriptionListModel::subscriptionAdded,
QSortFilterProxyModelPrivate::create_mapping calls
SubscriptionListModel::rowCount, which counts one extra row, leading to an
extra empty line.
This commit modifies rowCount to decrement by 1 during insertion.
Related: bug 407935, bug 420797

M  +9    -2    src/subscription/subscriptionlistmodel.cpp
M  +1    -0    src/subscription/subscriptionlistmodel.h

https://invent.kde.org/pim/akregator/-/commit/0c869e02caea41421d6a54feb2b03e3ec3aa9030

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Kdepim-bugs mailing list