[frameworks-kholidays] [Bug 445324] Winter solstice inappropriately listed as a holiday

[Alois Spitzbart]

https://bugs.kde.org/show_bug.cgi?id=445324

Alois Spitzbart <spitz234 at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |spitz234 at hotmail.com

--- Comment #7 from Alois Spitzbart <spitz234 at hotmail.com> ---
I searched and played around with kholiday. I found out, when I comment at
function
https://lxr.kde.org/source/frameworks/kholidays/src/parsers/holidayparserdriver.cpp#0049 
> Holiday::List HolidayParserDriver::parseHolidays(const QDate &startDate, const QDate &endDate)
following rows
>//    for (int year = startDate.year(); year < endDate.year(); ++year) {
>//        for (auto s : {AstroSeasons::JuneSolstice, AstroSeasons::DecemberSolstice, AstroSeasons::MarchEquinox, AstroSeasons::SeptemberEquinox}) {
>//            const auto dt = AstroSeasons::seasonDate(s, year);
>//            if (dt >= startDate && dt <= endDate) {
>//                Holiday season;
>//                season.d->mDayType = Holiday::Workday;
>//                season.d->mObservedDate = dt;
>//                season.d->mDuration = 1;
>//                season.d->mName = AstroSeasons::seasonName(s);
>//                season.d->mCategoryList.append(QLatin1String("seasonal"));
>//                m_resultList.append(season);
>//            }
>//        }
>//    }
everything works as expected. The autotests are also working. But I am not
experienced enough to see, what this is good for and what is the influence to
other parts.

-- 
You are receiving this mail because:
You are the assignee for the bug.