[akregator] [Bug 397752] HTML articles appear very small

[Laurent Montel]

https://bugs.kde.org/show_bug.cgi?id=397752

Laurent Montel <montel at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |montel at kde.org

--- Comment #6 from Laurent Montel <montel at kde.org> ---
(In reply to Lukáš Turek from comment #1)
> I have the same problem, but only on some feeds (websites): those that don't
> set fixed font size (in pt or px), but use relative units (em or rem).
> 
> I think it happens because QWebEngineSettings::DefaultFontSize expects the
> size in pixels, not points. However, GrantleeViewFormatter converts the
> configured Medium Font Size from points to pixels. This inconsistency means
> that depending on what Medium Font Size you set, you will either have normal
> fonts on websites and huge fonts in feeds, or tiny fonts on websites and
> normal fonts in feeds.
> 
> The simplest fix would be to drop the conversion in GrantleeViewFormatter,
> but that would change font size in feeds for current users.

"src/akregator_part.cpp:684:   
QWebEngineSettings::defaultSettings()->setFontSize(QWebEngineSettings::DefaultFontSize,
Settings::mediumFontSize());"
=> we use correct settings in QWebEngineSettings::defaultSettings() we don't
convert it.

In grantlee html file wr use
"grantleeObject.insert(QStringLiteral("mediumFontSize"),
pointsToPixel(Settings::mediumFontSize()));"
because
"rc/formatter/html/5.2/combinedview.html:9:    font-size: {{ mediumFontSize}}px
! important;
src/formatter/html/5.2/combinedview.html:65:    font-size:
{{mediumFontSize}}px;
src/formatter/html/5.2/combinedview.html:70:    font-size: {{
mediumFontSize}}px;
src/formatter/html/5.2/defaultnormalvisitfeed.html:8:    font-size: {{
mediumFontSize}}px ! important;
src/formatter/html/5.2/defaultnormalvisitfolder.html:8:    font-size: {{
mediumFontSize}}px ! important;
src/formatter/html/5.2/normalview.html:8:    font-size: {{ mediumFontSize}}px !
important;
src/formatter/html/5.2/normalview.html:50:    font-size: {{ mediumFontSize}}px;
src/formatter/html/5.2/normalview.html:55:    font-size: {{ mediumFontSize}}px;
"
we use px on html directly.

Which resolution do you use ? 4K ?

-- 
You are receiving this mail because:
You are the assignee for the bug.