[Akonadi] [Bug 421930] Crash when asking to input password

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=421930

Ahmad Samir <a.samirh78 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/pim/ |https://invent.kde.org/pim/
                   |kmailtransport/commit/14894 |kmailtransport/commit/c5fa8
                   |befa0274e124cdde611dfb7ada8 |cc88a1fc2df46dac279ba6b3b5e
                   |b1131b07                    |dfd553bb

--- Comment #6 from Ahmad Samir <a.samirh78 at gmail.com> ---
Git commit c5fa8cc88a1fc2df46dac279ba6b3b5edfd553bb by Ahmad Samir.
Committed on 07/11/2020 at 19:10.
Pushed by ahmadsamir into branch 'master'.

SmtpJob: Fix crash in startLoginJob

- The user tries to connect to an smtp server, the password dialog is shown
  starting a nested eventloop with exec()
- the connection is lost, the smtpjob is killed (due to connect() in
startSmtpJob)
- the dialog::exec returns, and the code tries to setError(KilledJobError)
  on an already killed job which leads to a crash

fix the issue by using QDialog::open() to make the code async.

https://invent.kde.org/pim/kmailtransport/-/merge_requests/4
(cherry picked from commit 14894befa0274e124cdde611dfb7ada8b1131b07)

M  +31   -21   src/kmailtransport/plugins/smtp/smtpjob.cpp

https://invent.kde.org/pim/kmailtransport/commit/c5fa8cc88a1fc2df46dac279ba6b3b5edfd553bb

-- 
You are receiving this mail because:
You are the assignee for the bug.