[korganizer] [Bug 409912] Quietly "saves" invalid event (incidence) start or end times as midnight (particularly affects fr_CA sub-locale)

bugzilla_noreply at kde.org bugzilla_noreply at kde.org
Sun Nov 1 15:17:14 GMT 2020


https://bugs.kde.org/show_bug.cgi?id=409912

--- Comment #2 from gjditchfield at acm.org ---
Git commit 701db76dc643d04fff14f9ee3875cd6654efdd34 by Glen Ditchfield.
Committed on 01/11/2020 at 02:01.
Pushed by gditchfield into branch 'master'.

Detect invalid start and end times

If the user enters an invalid string such as "25:00" into the start time field
or the end/due time field, IncidenceDateTime does not detect it, because the
QDateTime constructor used by currentStartDateTime() and currentEndDateTime()
treats it as "00:00".

This patch
 * detects and reports the error,
 * uses more specific error messages,
 * focuses on the erroneous field, and
 * logs at "debug" level, because the problem isn't very big.

M  +14   -0    autotests/CMakeLists.txt
A  +90   -0    autotests/incidencedatetimetest.cpp     [License: LGPL(v2.0+)]
M  +55   -10   src/incidencedatetime.cpp
M  +2    -0    src/incidencedatetime.h

https://invent.kde.org/pim/incidenceeditor/commit/701db76dc643d04fff14f9ee3875cd6654efdd34

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Kdepim-bugs mailing list