[akregator] [Bug 268158] Don't update .kde4/share/apps/akregator/data/feeds.opml if not change to prevent disk writing

[Aleksey Kladov]

https://bugs.kde.org/show_bug.cgi?id=268158

Aleksey Kladov <aleksey.kladov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleksey.kladov at gmail.com

--- Comment #1 from Aleksey Kladov <aleksey.kladov at gmail.com> ---
+1, but for a different reason. I store my .opml file in the git repo (to sync
it between machines):

https://github.com/matklad/config/blob/c97dcf8fc96ac837ad1dfe7cec67eeaae1e5d494/home/.local/share/akregator/data/feeds.opml

It looks like akregator always makes non-semantic changes to opml on startup
(changing the order of attributes), so I have to exclude opml from commit
manually. Looks like hashmap is used to represent XML and the iteration order
is leaked? 

I see two fixes:

* canonicalize the order of attributes (by using an ordered container instead
of a hash-based one)
* avoid writing the file unless there are semantically-meaningful changes

Probably makes sense to do both of these :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.