[korganizer] [Bug 405857] KOrganizer Calendar event time not saved

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=405857

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kwidgetsaddons/commi
                   |                            |t/37c9ebe699e33f84700489982
                   |                            |da301bdf8727bd3

--- Comment #9 from Albert Astals Cid <aacid at kde.org> ---
Git commit 37c9ebe699e33f84700489982da301bdf8727bd3 by Albert Astals Cid, on
behalf of Glen Ditchfield.
Committed on 02/07/2020 at 20:46.
Pushed by aacid into branch 'master'.

Fix KTimeComboBox for locales with unusual characters in formats

KTimeComboBox creates an edit mask by replacing the AM/PM indicator in
a formatted time with 'a' ("optional alphabetic") mask characters.
This does not work for locales that use punctuation in the indicator, such
as the current en_CA format "9:00 A.M.".  This patch uses mask character
'x' ("optional non-blank").

The current fr_CA time format contains an embedded 'h':  "9 h 00".  'h' is
an edit mask character ("optional hexadecimal digit"), so the generated
mask rejects properly-formatted times.  This patch escapes all characters
that are not supposed to be mask characters.

Credit to Filipus Klutiero for a detailed explanation of the errors.
```
Related: bug 406240, bug 409867, bug 410167, bug 411820, bug 412506, bug 420468
```

M  +52   -3    autotests/ktimecomboboxtest.cpp
M  +5    -0    autotests/ktimecomboboxtest.h
M  +26   -23   src/ktimecombobox.cpp

https://invent.kde.org/frameworks/kwidgetsaddons/commit/37c9ebe699e33f84700489982da301bdf8727bd3

-- 
You are receiving this mail because:
You are the assignee for the bug.